From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harvey Harrison Subject: Re: [PATCH] fbcon: replace mono_col macro with static inline Date: Tue, 26 Feb 2008 13:50:02 -0800 Message-ID: <1204062602.5582.38.camel@brick> References: <1203963237.5582.4.camel@brick> <1204059074.5582.35.camel@brick> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JU7gv-0001aI-2j for linux-fbdev-devel@lists.sourceforge.net; Tue, 26 Feb 2008 13:50:25 -0800 Received: from wa-out-1112.google.com ([209.85.146.178]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1JU7gt-0005LN-R6 for linux-fbdev-devel@lists.sourceforge.net; Tue, 26 Feb 2008 13:50:25 -0800 Received: by wa-out-1112.google.com with SMTP id k22so2891715waf.18 for ; Tue, 26 Feb 2008 13:50:23 -0800 (PST) In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Geert Uytterhoeven Cc: Andrew Morton , Linux Frame Buffer Device Development , LKML , Antonino Daplas On Tue, 2008-02-26 at 22:36 +0100, Geert Uytterhoeven wrote: > On Tue, 26 Feb 2008, Harvey Harrison wrote: > > On Tue, 2008-02-26 at 09:18 +0100, Geert Uytterhoeven wrote: > > > On Mon, 25 Feb 2008, Harvey Harrison wrote: > > > > +static inline int mono_col(struct fb_info *info) > > > ^^^^^^^^^^^^^^^^^^^^ > > > const struct fb_info *info? > > > > I suppose, but seeing as it's an inline, does it really matter? > > Sure, if one day a new routine calls mono_col() passing a const struct fb_info > pointer, it won't compile. Fair enough, want an updated patch, or will Andrew just make the small addition? Harvey ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/