From: Vitaliy Ivanov <vitalivanov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: torvalds@linux-foundation.org,
lkml <linux-kernel@vger.kernel.org>,
devzero@web.de, jsun@junsun.net, dwmw2@infradead.org,
protasnb@gmail.com, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH resend] Adding dummy release functions to avoid warnings.
Date: Thu, 05 Jun 2008 19:32:37 +0300 [thread overview]
Message-ID: <1212683557.21310.32.camel@dell1.softservecom.com> (raw)
In-Reply-To: <20080605090725.96da4b75.akpm@linux-foundation.org>
Andrew,
On Thu, 2008-06-05 at 19:07, Andrew Morton wrote:
> On Thu, 5 Jun 2008 12:39:46 +0300 "Vitaliy Ivanov" <vitalivanov@gmail.com> wrote:
> > Trivial fix for #9690.
> > Added simple release functions that doing nothing.
> > Not sure whether we can leave it as is or to rework using
> > platform_device helpers like platform_device_alloc.
>
> Please see Documentation/kobject.txt - search for the text
> "mocked mercilessly" :)
>
> > This approach is used in many drivers.
> > --
> >
> > drivers/mtd/maps/physmap.c | 6 ++++++
>
> Let's mock David too!
Damn. I knew that everything is not so easy here;) Got it. Tnx.
But in such case there are _again_ many drivers that do implement such
fake functions. Again is because when I tried to port some usb driver
there were issues with locking that was not correct but many drivers
worked exactly this incorrect way.
Anyway, tnx for clarifying this.
V.
prev parent reply other threads:[~2008-06-05 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1208306056.15140.13.camel@pcvitaliy>
[not found] ` <35fbaa3e0806050239y5987fc33rd349be8d07bc1262@mail.gmail.com>
2008-06-05 16:07 ` [PATCH resend] Adding dummy release functions to avoid warnings Andrew Morton
2008-06-05 16:31 ` David Woodhouse
2008-06-05 16:32 ` Vitaliy Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212683557.21310.32.camel@dell1.softservecom.com \
--to=vitalivanov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=devzero@web.de \
--cc=dwmw2@infradead.org \
--cc=jsun@junsun.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=protasnb@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).