Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] radeonfb: Give i2c buses nicer names
Date: Fri, 06 Jun 2008 19:21:37 +1000	[thread overview]
Message-ID: <1212744097.12464.29.camel@pasglop> (raw)
In-Reply-To: <20080606111955.5583e81a@hyperion.delvare>

On Fri, 2008-06-06 at 11:19 +0200, Jean Delvare wrote:
> The name of the i2c buses shows in the output of "i2cdetect -l", so
> it's important to give informative names.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/video/aty/radeon_i2c.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c	2008-06-03 09:57:31.000000000 +0200
> +++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c	2008-06-06 08:43:51.000000000 +0200
> @@ -69,7 +69,8 @@ static int radeon_setup_i2c_bus(struct r
>  {
>  	int rc;
>  
> -	strcpy(chan->adapter.name, name);
> +	snprintf(chan->adapter.name, sizeof(chan->adapter.name),
> +		 "radeonfb %s", name);
>  	chan->adapter.owner		= THIS_MODULE;
>  	chan->adapter.id		= I2C_HW_B_RADEON;
>  	chan->adapter.algo_data		= &chan->algo;
> 
> 


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

  reply	other threads:[~2008-06-06  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06  9:19 [PATCH] radeonfb: Give i2c buses nicer names Jean Delvare
2008-06-06  9:21 ` Benjamin Herrenschmidt [this message]
2008-06-08 13:50   ` Jean Delvare
2008-07-31  8:57     ` Andrew Morton
2008-07-31  9:00       ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2008-06-17 12:46 Jean Delvare
2008-06-18 18:57 ` Krzysztof Helt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212744097.12464.29.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=khali@linux-fr.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox