[PATCH] radeonfb: Revert "Fix radeon DDC regression"

[PATCH] radeonfb: Revert "Fix radeon DDC regression"

[Jean Delvare]

The bug was in fb_ddc and was fixed by commit
b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk)
so the workaround in radeonfb can be removed now.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
 drivers/video/aty/radeon_i2c.c |    4 ----
 1 file changed, 4 deletions(-)

--- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c	2008-06-06 08:43:51.000000000 +0200
+++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c	2008-06-06 09:28:50.000000000 +0200
@@ -139,12 +139,8 @@ void radeon_delete_i2c_busses(struct rad
 int radeon_probe_i2c_connector(struct radeonfb_info *rinfo, int conn,
 			       u8 **out_edid)
 {
-	u32 reg = rinfo->i2c[conn-1].ddc_reg;
 	u8 *edid;
 
-	OUTREG(reg, INREG(reg) &
-			~(VGA_DDC_DATA_OUTPUT | VGA_DDC_CLK_OUTPUT));
-
 	edid = fb_ddc_read(&rinfo->i2c[conn-1].adapter);
 
 	if (out_edid)


-- 
Jean Delvare

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

Re: [PATCH] radeonfb: Revert "Fix radeon DDC regression"

[Benjamin Herrenschmidt]

On Fri, 2008-06-06 at 11:21 +0200, Jean Delvare wrote:
> The bug was in fb_ddc and was fixed by commit
> b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk)
> so the workaround in radeonfb can be removed now.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---

I need to verify that on my Apple monitor which would switch off
if that is wrong. Will try to do that this week-end. Without news
from me next week, then just commit the bloody thing :-)

Cheers,
Ben.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

[PATCH] radeonfb: Revert "Fix radeon DDC regression"

[Jean Delvare]

The bug was in fb_ddc and was fixed by commit
b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk)
so the workaround in radeonfb can be removed now.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
Antonino, can you please push this upstream? Thanks.

 drivers/video/aty/radeon_i2c.c |    4 ----
 1 file changed, 4 deletions(-)

--- linux-2.6.26-rc5.orig/drivers/video/aty/radeon_i2c.c	2008-06-06 08:43:51.000000000 +0200
+++ linux-2.6.26-rc5/drivers/video/aty/radeon_i2c.c	2008-06-06 09:28:50.000000000 +0200
@@ -139,12 +139,8 @@ void radeon_delete_i2c_busses(struct rad
 int radeon_probe_i2c_connector(struct radeonfb_info *rinfo, int conn,
 			       u8 **out_edid)
 {
-	u32 reg = rinfo->i2c[conn-1].ddc_reg;
 	u8 *edid;
 
-	OUTREG(reg, INREG(reg) &
-			~(VGA_DDC_DATA_OUTPUT | VGA_DDC_CLK_OUTPUT));
-
 	edid = fb_ddc_read(&rinfo->i2c[conn-1].adapter);
 
 	if (out_edid)


-- 
Jean Delvare

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

Re: [PATCH] radeonfb: Revert "Fix radeon DDC regression"

[Andrew Morton]

On Sat, 07 Jun 2008 09:21:51 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> On Fri, 2008-06-06 at 11:21 +0200, Jean Delvare wrote:
> > The bug was in fb_ddc and was fixed by commit
> > b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk)
> > so the workaround in radeonfb can be removed now.
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > ---
> 
> I need to verify that on my Apple monitor which would switch off
> if that is wrong. Will try to do that this week-end. Without news
> from me next week, then just commit the bloody thing :-)
> 

I queued this for 2.6.28.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [PATCH] radeonfb: Revert "Fix radeon DDC regression"

[Benjamin Herrenschmidt]

On Thu, 2008-07-31 at 01:59 -0700, Andrew Morton wrote:
> On Sat, 07 Jun 2008 09:21:51 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
> > On Fri, 2008-06-06 at 11:21 +0200, Jean Delvare wrote:
> > > The bug was in fb_ddc and was fixed by commit
> > > b64d70825abbf706bbe80be1b11b09514b71f45e (fb_ddc: fix DDC lines quirk)
> > > so the workaround in radeonfb can be removed now.
> > > 
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > > ---
> > 
> > I need to verify that on my Apple monitor which would switch off
> > if that is wrong. Will try to do that this week-end. Without news
> > from me next week, then just commit the bloody thing :-)
> > 
> 
> I queued this for 2.6.28.

Ok. The monitor that was having problem is hooked on some other
stuff and I don't have the radeon machine in the same building
so unless people complain, I think this patch will do.

Ben.



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/