From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: roel kluin <roel.kluin@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RADEON: duplicate PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb
Date: Tue, 19 Aug 2008 08:06:40 +1000 [thread overview]
Message-ID: <1219097200.28339.94.camel@pasglop> (raw)
In-Reply-To: <48AA3900.80305@gmail.com>
On Mon, 2008-08-18 at 23:07 -0400, roel kluin wrote:
> untested, is it correct?
> ---
> duplicate PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb
Hard to say... this code originates from ATI. I'll have to dig a bit
to see what is the right bit combo I suppose.
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/video/aty/radeon_pm.c b/drivers/video/aty/radeon_pm.c
> index 675abda..74d2e65 100644
> --- a/drivers/video/aty/radeon_pm.c
> +++ b/drivers/video/aty/radeon_pm.c
> @@ -210,7 +210,7 @@ static void radeon_pm_disable_dynamic_mode(struct radeonfb_info *rinfo)
> PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> - PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> + PIXCLKS_CNTL__R300_P2G2CLK_DAC_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_DISP_DAC_PIXCLK_DAC2_BLANK_OFF);
> OUTPLL(pllPIXCLKS_CNTL, tmp);
>
> @@ -392,7 +392,7 @@ static void radeon_pm_enable_dynamic_mode(struct radeonfb_info *rinfo)
> PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> - PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb);
> + PIXCLKS_CNTL__R300_P2G2CLK_DAC_ALWAYS_ONb);
> OUTPLL(pllPIXCLKS_CNTL, tmp);
>
> tmp = INPLL(pllMCLK_MISC);
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
prev parent reply other threads:[~2008-08-18 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 3:07 [PATCH] RADEON: duplicate PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb roel kluin
2008-08-18 22:06 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219097200.28339.94.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).