Re: [Linux-fbdev-devel] [REVIEW PATCH 8/9] DSS: support for Beagle Board

[Tomi Valkeinen <tomi.valkeinen@nokia.com>]

On Tue, 2008-11-04 at 10:24 -0800, ext Tony Lindgren wrote:
> Hi,
> 
> One comment below.
> 
> * Tomi Valkeinen <tomi.valkeinen@nokia.com> [081104 08:32]:
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > ---
> > 
> >  arch/arm/mach-omap2/board-omap3beagle.c |  121 ++++++++++++++++++++++++++++---
> >  1 files changed, 108 insertions(+), 13 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> > index ce6c7b4..a6fe63d 100644
> > --- a/arch/arm/mach-omap2/board-omap3beagle.c
> > +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> 
> <snip>
> 
> > +static struct omap_fbmem_config beagle_fbmem0_config = {
> > +	.size = 1024*768*4,
> > +	.start = OMAPFB_MEMTYPE_SDRAM,
> > +};
> > +
> > +static struct omap_fbmem_config beagle_fbmem1_config = {
> > +	.size = 1024*768*4,
> > +	.start = OMAPFB_MEMTYPE_SDRAM,
> > +};
> > +
> > +static struct omap_fbmem_config beagle_fbmem2_config = {
> > +	.size = 1024*768*4,
> > +	.start = OMAPFB_MEMTYPE_SDRAM,
> > +};
> > +
> > +
> >  static struct omap_board_config_kernel omap3_beagle_config[] __initdata = {
> >  	{ OMAP_TAG_UART,	&omap3_beagle_uart_config },
> > -	{ OMAP_TAG_LCD,		&omap3_beagle_lcd_config },
> > +	{ OMAP_TAG_FBMEM,       &beagle_fbmem0_config },
> > +	{ OMAP_TAG_FBMEM,       &beagle_fbmem1_config },
> > +	{ OMAP_TAG_FBMEM,       &beagle_fbmem2_config },
> >  };
> >  
> 
> NAK for adding new OMAP_TAGs. We are in process of removing those.
> You should be able to use just board specific platform_data.
> 
> If there are ATAGs that are needed, they must be ARM generic. They
> also need to be acked by Russell King on the linux-arm-kernel mailing
> list. I doubt that you'll need those though.

Okay. But in this case, I think, it's not enough to have the board
specific data in board.c's platform_data. It would be good that the
bootloader can setup the display, and tell the relevant information to
the kernel, so that there are no glitches on the display (although not
currently implemented in my driver).

But there may be an ATAG that can be used for that, I'll have to check.

> Regards,
> 
> Tony

 Tomi