* [PATCH] Make radeon_reinitialize_M10() absent if its reference is #ifdef'd out
@ 2009-04-14 15:56 David Howells
2009-04-15 16:40 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2009-04-14 15:56 UTC (permalink / raw)
To: benh, linux-fbdev-devel; +Cc: dhowells, akpm, linux-kernel
Make radeon_reinitialize_M10() absent if its reference is #ifdef'd out (if
CONFIG_PM=n or CONFIG_PPC_PMAC=n. Otherwise a warning is given:
CC drivers/video/aty/radeon_pm.o
drivers/video/aty/radeon_pm.c:1720: warning: 'radeon_reinitialize_M10' defined but not used
Signed-off-by: David Howells <dhowells@redhat.com>
---
drivers/video/aty/radeon_pm.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/video/aty/radeon_pm.c b/drivers/video/aty/radeon_pm.c
index 97a1f09..8655bbd 100644
--- a/drivers/video/aty/radeon_pm.c
+++ b/drivers/video/aty/radeon_pm.c
@@ -1716,6 +1716,7 @@ static void radeon_pm_m10_reconfigure_mc(struct radeonfb_info *rinfo)
OUTREG(MC_IND_INDEX, 0);
}
+#if defined(CONFIG_PM) && defined(CONFIG_PPC_PMAC)
static void radeon_reinitialize_M10(struct radeonfb_info *rinfo)
{
u32 tmp, i;
@@ -1940,6 +1941,7 @@ static void radeon_reinitialize_M10(struct radeonfb_info *rinfo)
*/
radeon_pm_m10_enable_lvds_spread_spectrum(rinfo);
}
+#endif /* CONFIG_PM && CONFIG_PPC_PMAC */
#ifdef CONFIG_PPC_OF
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Make radeon_reinitialize_M10() absent if its reference is #ifdef'd out
2009-04-14 15:56 [PATCH] Make radeon_reinitialize_M10() absent if its reference is #ifdef'd out David Howells
@ 2009-04-15 16:40 ` Benjamin Herrenschmidt
2009-04-15 17:03 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2009-04-15 16:40 UTC (permalink / raw)
To: David Howells; +Cc: linux-fbdev-devel, akpm, linux-kernel
On Tue, 2009-04-14 at 16:56 +0100, David Howells wrote:
> Make radeon_reinitialize_M10() absent if its reference is #ifdef'd out
> (if
> CONFIG_PM=n or CONFIG_PPC_PMAC=n. Otherwise a warning is given:
>
> CC drivers/video/aty/radeon_pm.o
> drivers/video/aty/radeon_pm.c:1720: warning: 'radeon_reinitialize_M10'
> defined but not used
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Nah. You ifdef it with CONFIG_PPC_PMAC, but it can be used on x86
too (see the "BUGFIX" entries).
Cheers,
Ben.
> ---
>
> drivers/video/aty/radeon_pm.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>
> diff --git a/drivers/video/aty/radeon_pm.c
> b/drivers/video/aty/radeon_pm.c
> index 97a1f09..8655bbd 100644
> --- a/drivers/video/aty/radeon_pm.c
> +++ b/drivers/video/aty/radeon_pm.c
> @@ -1716,6 +1716,7 @@ static void radeon_pm_m10_reconfigure_mc(struct radeonfb_info *rinfo)
> OUTREG(MC_IND_INDEX, 0);
> }
>
> +#if defined(CONFIG_PM) && defined(CONFIG_PPC_PMAC)
> static void radeon_reinitialize_M10(struct radeonfb_info *rinfo)
> {
> u32 tmp, i;
> @@ -1940,6 +1941,7 @@ static void radeon_reinitialize_M10(struct radeonfb_info *rinfo)
> */
> radeon_pm_m10_enable_lvds_spread_spectrum(rinfo);
> }
> +#endif /* CONFIG_PM && CONFIG_PPC_PMAC */
>
> #ifdef CONFIG_PPC_OF
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-15 17:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-14 15:56 [PATCH] Make radeon_reinitialize_M10() absent if its reference is #ifdef'd out David Howells
2009-04-15 16:40 ` Benjamin Herrenschmidt
2009-04-15 17:03 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).