From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [Linux-fbdev-devel] [PATCH] offb: use framebuffer_alloc() to allocate fb_info struct Date: Fri, 15 May 2009 16:28:34 +1000 Message-ID: <1242368914.22331.18.camel@pasglop> References: <20090504190724.c2dfb53c.krzysztof.h1@poczta.fm> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090504190724.c2dfb53c.krzysztof.h1@poczta.fm> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org To: Krzysztof Helt Cc: linuxppc-dev@ozlabs.org, Andrew Morton , Linux-fbdev-devel , Geert Uytterhoeven On Mon, 2009-05-04 at 19:07 +0200, Krzysztof Helt wrote: > From: Krzysztof Helt > > Use the framebuffer_alloc() function to allocate the fb_info > structure so the structure is correctly initialized after allocation. > > Signed-off-by: Krzysztof Helt Acked-by: Benjamin Herrenschmidt --- > --- > > diff -urp linux-orig/drivers/video/offb.c linux-2.6.30/drivers/video/offb.c > --- linux-orig/drivers/video/offb.c 2008-08-09 05:09:05.000000000 +0200 > +++ linux-2.6.30/drivers/video/offb.c 2009-05-04 00:14:28.000000000 +0200 > @@ -378,7 +378,6 @@ static void __init offb_init_fb(const ch > struct fb_fix_screeninfo *fix; > struct fb_var_screeninfo *var; > struct fb_info *info; > - int size; > > if (!request_mem_region(res_start, res_size, "offb")) > return; > @@ -393,15 +392,12 @@ static void __init offb_init_fb(const ch > return; > } > > - size = sizeof(struct fb_info) + sizeof(u32) * 16; > - > - info = kmalloc(size, GFP_ATOMIC); > + info = framebuffer_alloc(sizeof(u32) * 16, NULL); > > if (info == 0) { > release_mem_region(res_start, res_size); > return; > } > - memset(info, 0, size); > > fix = &info->fix; > var = &info->var; > > ---------------------------------------------------------------------- > Wygraj 3000 zl, wycieczke lub lot balonem! > Sprawdz >> http://link.interia.pl/f2154 > > > ------------------------------------------------------------------------------ > Register Now & Save for Velocity, the Web Performance & Operations > Conference from O'Reilly Media. Velocity features a full day of > expert-led, hands-on workshops and two days of sessions from industry > leaders in dedicated Performance & Operations tracks. Use code vel09scf > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > _______________________________________________ > Linux-fbdev-devel mailing list > Linux-fbdev-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel