From: Harald Welte <HaraldWelte@viatech.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Harald Welte <HaraldWelte@viatech.com>
Subject: [PATCH 01/15] [FB] make viafb work on x86_64
Date: Thu, 21 May 2009 04:28:39 +0800 [thread overview]
Message-ID: <1242851333-325-1-git-send-email-HaraldWelte@viatech.com> (raw)
From: Harald Welte <laforge@gnumonks.org>
This patch makes fixes a bug in viafb on x86_64 builds (e.g. for VIA Nano CPU).
You cannot make the assumption that sizeof(unsigned int) == sizeof(unsigned
long), so the parsing of the default mode (640x480) fails, leading to a
division by zero during insmod of the driver.
Signed-off-by: Harald Welte <HaraldWelte@viatech.com>
---
drivers/video/via/viafbdev.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c
index e327b84..a0fec29 100644
--- a/drivers/video/via/viafbdev.c
+++ b/drivers/video/via/viafbdev.c
@@ -2103,7 +2103,7 @@ static void viafb_remove_proc(struct proc_dir_entry *viafb_entry)
static int __devinit via_pci_probe(void)
{
- unsigned int default_xres, default_yres;
+ unsigned long default_xres, default_yres;
char *tmpc, *tmpm;
char *tmpc_sec, *tmpm_sec;
int vmode_index;
@@ -2196,8 +2196,8 @@ static int __devinit via_pci_probe(void)
viafb_FB_MM = viaparinfo->fbmem_virt;
tmpm = viafb_mode;
tmpc = strsep(&tmpm, "x");
- strict_strtoul(tmpc, 0, (unsigned long *)&default_xres);
- strict_strtoul(tmpm, 0, (unsigned long *)&default_yres);
+ strict_strtoul(tmpc, 0, &default_xres);
+ strict_strtoul(tmpm, 0, &default_yres);
vmode_index = viafb_get_mode_index(default_xres, default_yres, 0);
DEBUG_MSG(KERN_INFO "0->index=%d\n", vmode_index);
--
1.6.2.4
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
next reply other threads:[~2009-05-20 20:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 20:28 Harald Welte [this message]
2009-05-20 20:28 ` [PATCH 02/15] [FB] viafb: Add missing break statement in switch Harald Welte
2009-05-20 20:28 ` [PATCH 03/15] [FB] viafb: Add support for the VX855 chipset Harald Welte
2009-05-20 20:28 ` [PATCH 04/15] [FB] viafb: Fix various resource leaks during module_init() Harald Welte
2009-05-20 20:28 ` [PATCH 05/15] [FB] viafb: make viafb a first-class citizen using pci_driver Harald Welte
2009-05-20 20:28 ` [PATCH 06/15] viafb: pass reference to pci device when calling framebuffer_alloc() Harald Welte
2009-05-20 20:28 ` [PATCH 07/15] viafb: use proper pci config API Harald Welte
2009-05-20 20:28 ` [PATCH 08/15] viafb: get rid of some duplicated fields in private structure Harald Welte
2009-05-20 20:28 ` [PATCH 09/15] viafb: Remove MMIO from " Harald Welte
2009-05-20 20:28 ` [PATCH 10/15] viafb: make module parameters visible in sysfs Harald Welte
2009-05-20 20:28 ` [PATCH 11/15] viafb: clean up duplicated code from 2D acceleration Harald Welte
2009-05-20 20:28 ` [PATCH 12/15] viafb: introduce wrapper for 2D engine registers Harald Welte
2009-05-20 20:28 ` [PATCH 13/15] viafb: initialize 2D engine registers from loop Harald Welte
2009-05-20 20:28 ` [PATCH 14/15] viafb: Determine type of 2D engine and store it in chip_info Harald Welte
2009-05-20 20:28 ` [PATCH 15/15] viafb: Add support for 2D accelerated framebuffer on VX800/VX855 Harald Welte
2009-05-23 6:31 ` Krzysztof Helt
2009-05-23 6:29 ` [PATCH 14/15] viafb: Determine type of 2D engine and store it in chip_info Krzysztof Helt
2009-05-23 6:27 ` [PATCH 13/15] viafb: initialize 2D engine registers from loop Krzysztof Helt
2009-05-23 9:33 ` Harald Welte
2009-05-23 6:28 ` [PATCH 12/15] viafb: introduce wrapper for 2D engine registers Krzysztof Helt
2009-05-23 6:28 ` [PATCH 11/15] viafb: clean up duplicated code from 2D acceleration Krzysztof Helt
2009-05-23 6:32 ` [PATCH 10/15] viafb: make module parameters visible in sysfs Krzysztof Helt
2009-05-23 6:32 ` [PATCH 09/15] viafb: Remove MMIO from private structure Krzysztof Helt
2009-05-23 6:34 ` [PATCH 08/15] viafb: get rid of some duplicated fields in " Krzysztof Helt
2009-05-23 6:52 ` [PATCH 07/15] viafb: use proper pci config API Krzysztof Helt
2009-05-23 6:52 ` [PATCH 06/15] viafb: pass reference to pci device when calling framebuffer_alloc() Krzysztof Helt
2009-05-23 6:53 ` [PATCH 05/15] [FB] viafb: make viafb a first-class citizen using pci_driver Krzysztof Helt
2009-05-23 6:53 ` [PATCH 04/15] [FB] viafb: Fix various resource leaks during module_init() Krzysztof Helt
2009-05-23 6:54 ` [PATCH 03/15] [FB] viafb: Add support for the VX855 chipset Krzysztof Helt
2009-05-23 6:54 ` [PATCH 02/15] [FB] viafb: Add missing break statement in switch Krzysztof Helt
2009-05-21 16:57 ` [PATCH 01/15] [FB] make viafb work on x86_64 Krzysztof Helt
2009-05-23 6:57 ` Krzysztof Helt
2009-05-23 9:06 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242851333-325-1-git-send-email-HaraldWelte@viatech.com \
--to=haraldwelte@viatech.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).