* [PATCH] radeon: P2G2CLK_ALWAYS_ONb tested twice, should 2nd be P2G2CLK_DAC_ALWAYS_ONb?
@ 2009-05-15 20:45 Roel Kluin
2009-05-28 6:54 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-05-15 20:45 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Andrew Morton, linux-fbdev-devel
P2G2CLK_ALWAYS_ONb is tested twice, 2nd should be P2G2CLK_DAC_ALWAYS_ONb.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Is this correct? I am only guessing. Please review.
diff --git a/drivers/video/aty/radeon_pm.c b/drivers/video/aty/radeon_pm.c
index 97a1f09..100112f 100644
--- a/drivers/video/aty/radeon_pm.c
+++ b/drivers/video/aty/radeon_pm.c
@@ -395,7 +395,7 @@ static void radeon_pm_enable_dynamic_mode(struct radeonfb_info *rinfo)
PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
- PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb);
+ PIXCLKS_CNTL__R300_P2G2CLK_DAC_ALWAYS_ONb);
OUTPLL(pllPIXCLKS_CNTL, tmp);
tmp = INPLL(pllMCLK_MISC);
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] radeon: P2G2CLK_ALWAYS_ONb tested twice, should 2nd be P2G2CLK_DAC_ALWAYS_ONb?
2009-05-15 20:45 [PATCH] radeon: P2G2CLK_ALWAYS_ONb tested twice, should 2nd be P2G2CLK_DAC_ALWAYS_ONb? Roel Kluin
@ 2009-05-28 6:54 ` Andrew Morton
2009-05-28 7:11 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2009-05-28 6:54 UTC (permalink / raw)
To: Roel Kluin; +Cc: Benjamin Herrenschmidt, linux-fbdev-devel
On Fri, 15 May 2009 22:45:27 +0200 Roel Kluin <roel.kluin@gmail.com> wrote:
> P2G2CLK_ALWAYS_ONb is tested twice, 2nd should be P2G2CLK_DAC_ALWAYS_ONb.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Is this correct? I am only guessing. Please review.
Nobody knows?
> diff --git a/drivers/video/aty/radeon_pm.c b/drivers/video/aty/radeon_pm.c
> index 97a1f09..100112f 100644
> --- a/drivers/video/aty/radeon_pm.c
> +++ b/drivers/video/aty/radeon_pm.c
> @@ -395,7 +395,7 @@ static void radeon_pm_enable_dynamic_mode(struct radeonfb_info *rinfo)
> PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> - PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb);
> + PIXCLKS_CNTL__R300_P2G2CLK_DAC_ALWAYS_ONb);
> OUTPLL(pllPIXCLKS_CNTL, tmp);
>
> tmp = INPLL(pllMCLK_MISC);
The same thing happens at line 215:
tmp &= ~(PIXCLKS_CNTL__PIX2CLK_ALWAYS_ONb |
PIXCLKS_CNTL__PIX2CLK_DAC_ALWAYS_ONb |
PIXCLKS_CNTL__DISP_TVOUT_PIXCLK_TV_ALWAYS_ONb |
PIXCLKS_CNTL__R300_DVOCLK_ALWAYS_ONb |
PIXCLKS_CNTL__PIXCLK_BLEND_ALWAYS_ONb |
PIXCLKS_CNTL__PIXCLK_GV_ALWAYS_ONb |
PIXCLKS_CNTL__R300_PIXCLK_DVO_ALWAYS_ONb |
PIXCLKS_CNTL__PIXCLK_LVDS_ALWAYS_ONb |
PIXCLKS_CNTL__PIXCLK_TMDS_ALWAYS_ONb |
PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
PIXCLKS_CNTL__R300_DISP_DAC_PIXCLK_DAC2_BLANK_OFF);
but that's easier to fix.
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] radeon: P2G2CLK_ALWAYS_ONb tested twice, should 2nd be P2G2CLK_DAC_ALWAYS_ONb?
2009-05-28 6:54 ` Andrew Morton
@ 2009-05-28 7:11 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2009-05-28 7:11 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-fbdev-devel
On Wed, 2009-05-27 at 23:54 -0700, Andrew Morton wrote:
> On Fri, 15 May 2009 22:45:27 +0200 Roel Kluin <roel.kluin@gmail.com> wrote:
>
> > P2G2CLK_ALWAYS_ONb is tested twice, 2nd should be P2G2CLK_DAC_ALWAYS_ONb.
> >
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > Is this correct? I am only guessing. Please review.
>
> Nobody knows?
It looks ok, I've acked it, we'll see how it goes :-)
Cheers,
Ben.
> > diff --git a/drivers/video/aty/radeon_pm.c b/drivers/video/aty/radeon_pm.c
> > index 97a1f09..100112f 100644
> > --- a/drivers/video/aty/radeon_pm.c
> > +++ b/drivers/video/aty/radeon_pm.c
> > @@ -395,7 +395,7 @@ static void radeon_pm_enable_dynamic_mode(struct radeonfb_info *rinfo)
> > PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
> > PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
> > PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> > - PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb);
> > + PIXCLKS_CNTL__R300_P2G2CLK_DAC_ALWAYS_ONb);
> > OUTPLL(pllPIXCLKS_CNTL, tmp);
> >
> > tmp = INPLL(pllMCLK_MISC);
>
> The same thing happens at line 215:
>
> tmp &= ~(PIXCLKS_CNTL__PIX2CLK_ALWAYS_ONb |
> PIXCLKS_CNTL__PIX2CLK_DAC_ALWAYS_ONb |
> PIXCLKS_CNTL__DISP_TVOUT_PIXCLK_TV_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_DVOCLK_ALWAYS_ONb |
> PIXCLKS_CNTL__PIXCLK_BLEND_ALWAYS_ONb |
> PIXCLKS_CNTL__PIXCLK_GV_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_PIXCLK_DVO_ALWAYS_ONb |
> PIXCLKS_CNTL__PIXCLK_LVDS_ALWAYS_ONb |
> PIXCLKS_CNTL__PIXCLK_TMDS_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_PIXCLK_TRANS_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_PIXCLK_TVO_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_P2G2CLK_ALWAYS_ONb |
> PIXCLKS_CNTL__R300_DISP_DAC_PIXCLK_DAC2_BLANK_OFF);
>
> but that's easier to fix.
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-28 7:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-15 20:45 [PATCH] radeon: P2G2CLK_ALWAYS_ONb tested twice, should 2nd be P2G2CLK_DAC_ALWAYS_ONb? Roel Kluin
2009-05-28 6:54 ` Andrew Morton
2009-05-28 7:11 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).