From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0752C82C7E for ; Wed, 4 Sep 2024 06:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725430183; cv=none; b=JBY/LSmR99bOYdM9rlZinOJFVH/ABoZltQoCKqcMksda1tq1hc/Wj9X9geOl4ds5iYlnoNKrR39hYcBK9aB4yLi4/kN5ossq4klkl0JZ9Dc4oMD0Ga/YWaCOTn3qE/EslPBTGib2S1qFUiYl6rlaLp8Hj0UxvOu/OldmKXM+pCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725430183; c=relaxed/simple; bh=/ap0Lb0p2D10FtCEsvoePod2hYOhBoErt1/GKFZ3DmQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MryIw0/H1SDsRIPnq4dkPsT+Y7fvxelXd/aLDc06FRL4/RN56B1i5V5IjILa6bWHlvoKI8cHc6TxhcPXX7LAeQsr1ZOZQs/ykYoNF7mik2BF8a8O1sUerot/5MLg3hqkQSkA7PVAPQv+mf1cO716UVDQtZgD/qAfUWMfRzjBHak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=EyW520UD; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=Z9i4jIm+ reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="EyW520UD"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="Z9i4jIm+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1725430180; x=1756966180; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9DNqPebhl2qJdhBypVsuWI2E262XFeeAgAIjR7kOhR8=; b=EyW520UD+cMDxceq2FBNZ6iLhoOO4siKWk+t6Qltkf+y4NOJccqXdj+o I+xgF/gJ4HoOFkZPE9K+r87xG+jv4fuE8r72/wqRmJ9PMlKpPfgk/9/n2 T9Na6YDarQYA56IMLFYSM2zV457RiTu7keJba7VMIl0lYVqUsTqq7rtb8 H+v0XeRNCp9iW97DnQ6dySSd2o+oPRUCERV79wZpYP18+8+ymGrxzDjJS oJnSEYIThCSmmy2f9y49+TYGz8Y2T+EnnxR8mSLyO9y6dxedx8EqYm16g Z3pC+WlGU0WkHxudJb2jcVln2FcNqg8QwLtjBbx1uCGU+wmn9A0THzAUk A==; X-CSE-ConnectionGUID: KjR7ONlmQQGnabThcFbHlw== X-CSE-MsgGUID: wo6p52RhThK9xj4chs/paQ== X-IronPort-AV: E=Sophos;i="6.10,201,1719871200"; d="scan'208";a="38750373" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 04 Sep 2024 08:09:32 +0200 X-CheckPoint: {66D7F99C-3-5FF8EC80-F6CEE9F8} X-MAIL-CPID: 246AB71334F08AD1F3685D08755CD23D_0 X-Control-Analysis: str=0001.0A782F25.66D7F99C.005A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B69E316A970; Wed, 4 Sep 2024 08:09:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1725430167; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=9DNqPebhl2qJdhBypVsuWI2E262XFeeAgAIjR7kOhR8=; b=Z9i4jIm+ZBjmwYC8KfEL+lqNp+0acDq1XAzD6UnZta/G+b9/Ro/CqIL6AuWoxaQQ1jOqG9 lJlcsMevvuT3hiWeY8thU4AB9/zDfJtoK6X8hwyka7ONAdZ5oXkGdC7cmJGy8U4RMAmr/2 B9VjSCaUkEXXgKZbfUMDu8Ow7FSUk9oSHm/loHzqP+3MB+9XunTpYPyWmZ8yTFl273hKXx 5dgvNEfggWamJBgv94882Jq6sMGglOPdXBav1WBOg77dqve3/z7Jb5WFNcgQTUBw9n/PBL 5OEs4QKw7fTXWUBMN+C0zIfBb+ieXuHY0tJKXOQRAqf37tcHXYDEA2g/KT1DVw== From: Alexander Stein To: Thomas Zimmermann , dri-devel@lists.freedesktop.org Cc: javierm@redhat.com, deller@gmx.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v3 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O Date: Wed, 04 Sep 2024 08:09:25 +0200 Message-ID: <12510239.O9o76ZdvQC@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20240419083331.7761-1-tzimmermann@suse.de> <20240419083331.7761-22-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Last-TLS-Session-Version: TLSv1.3 Hi Linus, Am Mittwoch, 4. September 2024, 00:53:42 CEST schrieb Linus Walleij: > On Fri, Apr 19, 2024 at 10:35=E2=80=AFAM Thomas Zimmermann wrote: >=20 > > Add support for damage handling and deferred I/O to fbdev-dma. This > > enables fbdev-dma to support all DMA-memory-based DRM drivers, even > > such with a dirty callback in their framebuffers. > > > > The patch adds the code for deferred I/O and also sets a dedicated > > helper for struct fb_ops.fb_mmap that support coherent mappings. > > > > v3: > > - init fb_ops with FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS() (Javier) > > > > Signed-off-by: Thomas Zimmermann > > Reviewed-by: Javier Martinez Canillas >=20 > For some reason this makes the Versatile Express crash in QEMU > (I can retest on real hardware if necessary): This commit also breaks i.MX6 on actual hardware, see [1]. [1] https://lore.kernel.org/all/23636953.6Emhk5qWAg@steina-w/ > 8<--- cut here --- > Unable to handle kernel paging request at virtual address 18095000 when w= rite > [18095000] *pgd=3D00000000 > Internal error: Oops: 805 [#1] SMP ARM > CPU: 0 PID: 75 Comm: S08_ledflash Not tainted 6.9.0-rc6+ #44 > Hardware name: ARM-Versatile Express > PC is at mmioset+0x34/0xac > LR is at 0x0 > pc : [<809c2a54>] lr : [<00000000>] psr: 20000013 > sp : f8dddc38 ip : 18095000 fp : 00000000 > r10: 81109a18 r9 : 81238b04 r8 : 00000000 > r7 : 00440dc0 r6 : ed4f32a0 r5 : ed4f32a0 r4 : 00000001 > r3 : 00000000 r2 : 00000fc0 r1 : 00000000 r0 : 18095000 > Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none > Control: 10c5387d Table: 81d6406a DAC: 00000051 > Register r0 information: non-paged memory > Register r1 information: NULL pointer > Register r2 information: non-paged memory > Register r3 information: NULL pointer > Register r4 information: non-paged memory > Register r5 information: non-slab/vmalloc memory > Register r6 information: non-slab/vmalloc memory > Register r7 information: non-paged memory > Register r8 information: NULL pointer > Register r9 information: non-slab/vmalloc memory > Register r10 information: non-slab/vmalloc memory > Register r11 information: NULL pointer > Register r12 information: non-paged memory > Process S08_ledflash (pid: 75, stack limit =3D 0x(ptrval)) > Stack: (0xf8dddc38 to 0xf8dde000) > dc20: 00000801 802a= f888 > dc40: 80a0fb80 00440dc0 00000801 811fad80 00000000 f8dddd28 ed4f32a0 811f= a680 > dc60: 00000000 802b0c30 ee1d2140 ee1d215c 95ff4385 00000001 00000001 0000= 0001 > dc80: 00000000 00000000 ffffffff 8196a70b 000000b0 00000064 0000006c 0000= 0000 > dca0: 00000001 00000002 00000001 811fa798 00000801 811fa940 80a0fb80 0000= 0cc0 > dcc0: 00000001 00000001 00000000 f8dddd28 811fa93c 811fa680 00000002 802b= 0c30 > dce0: ee1d2140 00440dc0 00000000 00000000 00000001 00000000 811fad80 0044= 0dc0 > dd00: 00000001 00000000 00000000 83201100 00440dc0 00000000 00000000 802a= fa18 > dd20: 00000bdc 00000bd8 811fad80 00000000 811fad80 00000000 00000000 0000= 0000 > dd40: adf00ec5 816d5fa8 816d5fa8 821c3c00 00000000 7ebc2000 7ebe3000 0000= 0000 > dd60: f8ddde44 8028cfa0 816d5fa8 8288df50 8169cf00 821c3c00 7ebc2000 7ebe= 3000 > dd80: f8ddde44 8028e1e8 00000001 80bbe932 f8ddde44 f8dddde8 f8ddde44 8288= df50 > dda0: 83201100 809cf474 f8ddde44 8169cf00 00000020 8169cf94 821c3c94 7ebe= 3000 > ddc0: 7ebe2fff fffffff4 00000000 816d5fa8 821c3c00 8169cf00 81d65fa8 809c= dbb0 > dde0: 8288df50 81ffa910 7ebe3000 82890b00 00000000 00000000 00000000 0000= 0000 > de00: 00000000 00000000 adf00ec5 00000000 00000000 8169cf00 8288df50 8320= 1100 > de20: 821c3c00 81ffa910 f8ddde44 8011f6e4 00000000 00000000 821c3c7c 8169= cf7c > de40: 83200880 821c3c40 7ebc2000 7ebe2fff 82890b0c 76ea4000 ffffffff 0000= 0000 > de60: 00000000 0f000a01 f8ddde68 f8ddde68 adf00ec5 00000000 00000000 0000= 0000 > de80: 00000000 01200000 83201100 00000000 00000000 8011e2ac 00000000 8320= 0d7c > dea0: 83201020 83200e70 83200e80 00000000 f8dddf30 83200880 00000000 0000= 0000 > dec0: 00000000 00000000 00000000 82182f38 adf00ec5 00000000 01200000 f8dd= df30 > dee0: 00000000 00000000 00000000 00000078 000cb21c 8011fe24 00000020 0000= 0000 > df00: 828a5d80 80a10140 adf00ec5 01200011 00000000 00000000 00000000 f8dd= df30 > df20: 00000000 00000078 000cb21c 801203d4 01200000 00000000 00000000 76f4= 6468 > df40: 00000000 00000000 00000011 00000000 00000000 00000000 00000000 0000= 0000 > df60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 0000= 0000 > df80: 00000003 adf00ec5 76f46468 00000000 76f468c0 00000078 80100290 8320= 1100 > dfa0: 000cb21c 80100060 76f46468 00000000 01200011 00000000 00000000 0000= 0000 > dfc0: 76f46468 00000000 76f468c0 00000078 00000000 76e81000 76f46400 000c= b21c > dfe0: 00000078 7ebe2938 76e0854d 76dae7e6 20000030 01200011 00000000 0000= 0000 > Call trace: > mmioset from prep_new_page+0x160/0x194 > prep_new_page from get_page_from_freelist+0x10f4/0x110c > get_page_from_freelist from __alloc_pages+0x15c/0x280 > __alloc_pages from __pte_alloc+0x28/0x1bc > __pte_alloc from copy_page_range+0xc10/0xd28 > copy_page_range from copy_mm+0x5cc/0x850 > copy_mm from copy_process+0x508/0xd8c > copy_process from kernel_clone+0x94/0x338 > kernel_clone from sys_clone+0x94/0xb0 > sys_clone from ret_fast_syscall+0x0/0x1c > Exception stack(0xf8dddfa8 to 0xf8dddff0) > dfa0: 76f46468 00000000 01200011 00000000 00000000 0000= 0000 > dfc0: 76f46468 00000000 76f468c0 00000078 00000000 76e81000 76f46400 000c= b21c > dfe0: 00000078 7ebe2938 76e0854d 76dae7e6 > Code: e92d4100 e1a08001 e1a0e003 e2522040 (a8ac410a) > ---[ end trace 0000000000000000 ]--- >=20 > I bisected down to this commit and reverting the commit solves the issue. >=20 > What is special about the Versatile Express graphics is that it uses a sp= ecial > dedicated video RAM, looks like this in the device tree >=20 >=20 > reserved-memory { > #address-cells =3D <1>; > #size-cells =3D <1>; > ranges; >=20 > /* Chipselect 3 is physically at 0x4c000000 */ > vram: vram@4c000000 { > /* 8 MB of designated video RAM */ > compatible =3D "shared-dma-pool"; > reg =3D <0x4c000000 0x00800000>; Can you please check in which memory zone this VRAM is located. In my case it's important CMA is located in Normal zone to trigger this problem. Best regards, Alexander > no-map; > }; > }; > (...) > clcd@1f000 { > compatible =3D "arm,pl111", "arm,primecell"; > (...) > memory-region =3D <&vram>; >=20 > This gets picked up in the driver > drivers/gpu/drm/pl111/pl111_drv.c > like this: >=20 > ret =3D of_reserved_mem_device_init(dev); > if (!ret) { > dev_info(dev, "using device-specific reserved memory\n"); > priv->use_device_memory =3D true; > } >=20 > Yours, > Linus Walleij >=20 =2D-=20 TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ= any Amtsgericht M=C3=BCnchen, HRB 105018 Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch= neider http://www.tq-group.com/