From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] aty128fb: move block to where it should be in function aty128_var_to_pll
Date: Tue, 22 Sep 2009 09:51:12 +1000 [thread overview]
Message-ID: <1253577072.7103.168.camel@pasglop> (raw)
In-Reply-To: <1253537843.3207.5.camel@ht.satnam>
On Mon, 2009-09-21 at 18:27 +0530, Jaswinder Singh Rajput wrote:
> Indentation is not an issue if I am not breaking any lines. I am
> moving
> the function where it should be and avoid unnecessary goto(break) and
> duplicate checking 'if (i == ARRAY_SIZE(post_dividers))'.
Where it "should be" is a matter of taste :-)
> > If you really want to silence that warning, just initialize the
> value
> >
>
> I am trying to save some CPU cycles and you are suggesting to add some
> more ;-)
Saving CPU cycles in the mode setting code ? :-)
Anyway, Paul maintains this driver afaik so it's his call :-)
Cheers,
Ben.
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
prev parent reply other threads:[~2009-09-22 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 8:14 [PATCH] aty128fb: move block to where it should be in function aty128_var_to_pll Jaswinder Singh Rajput
2009-09-20 22:19 ` Benjamin Herrenschmidt
2009-09-21 12:57 ` Jaswinder Singh Rajput
2009-09-21 23:51 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253577072.7103.168.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jaswinder@kernel.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).