From: Anatolij Gustschin <agust@denx.de>
To: linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] mx3fb: Fix display brightness initialization
Date: Mon, 9 Nov 2009 12:10:07 +0100 [thread overview]
Message-ID: <1257765007-32040-1-git-send-email-agust@denx.de> (raw)
__blank() uses mx3fb->backlight_level to set the
display brightness. __blank() is also called from
init_fb_chan() before mx3fb->backlight_level was
initialized. This causes setting the display brightness
to zero at probe time.
This patch moves the initialization of mx3fb->backlight_level
before init_fb_chan() call.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
drivers/video/mx3fb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index 054ef29..86312dd 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c
@@ -1486,12 +1486,12 @@ static int mx3fb_probe(struct platform_device *pdev)
goto ersdc0;
}
+ mx3fb->backlight_level = 255;
+
ret = init_fb_chan(mx3fb, to_idmac_chan(chan));
if (ret < 0)
goto eisdc0;
- mx3fb->backlight_level = 255;
-
return 0;
eisdc0:
--
1.5.6.3
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
reply other threads:[~2009-11-09 11:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257765007-32040-1-git-send-email-agust@denx.de \
--to=agust@denx.de \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).