From: 한진구 <jg1.han@samsung.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 19/29] s3c-fb: use display information in info not in var
Date: Fri, 27 May 2011 00:45:58 +0000 [thread overview]
Message-ID: <12589456.8031306457158097.JavaMail.weblogic@epml08> (raw)
In-Reply-To: <1306364301-8195-20-git-send-email-laurent.pinchart@ideasonboard.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1378 bytes --]
Acked-by: Jingoo Han <jg1.han@samsung.com>
> ------- Original Message -------
> Sender : Laurent Pinchart<laurent.pinchart@ideasonboard.com>
> Date : 2011-05-26 07:58 (GMT+09:00)
> Title : [PATCH 19/29] s3c-fb: use display information in info not in var for
> panning
>
> We must not use any information in the passed var besides xoffset,
> yoffset and vmode as otherwise applications might abuse it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Ben Dooks <ben@simtec.co.uk>
> Cc: InKi Dae <inki.dae@samsung.com>
> ---
> drivers/video/s3c-fb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 3b6cdca..4fce307 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -882,7 +882,7 @@ static int s3c_fb_pan_display(struct fb_var_screeninfo *var,
> }
> }
> /* Offset in bytes to the end of the displayed area */
> - end_boff = start_boff + var->yres * info->fix.line_length;
> + end_boff = start_boff + info->var.yres * info->fix.line_length;
>
> /* Temporarily turn off per-vsync update from shadow registers until
> * both start and end addresses are updated to prevent corruption */
> --
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±ýöÝzÿâØ^nr¡ö¦zË\x1aëh¨èÚ&£ûàz¿äz¹Þú+Ê+zf£¢·h§~Ûiÿÿïêÿêçz_è®\x0fæj:+v¨þ)ߣøm
prev parent reply other threads:[~2011-05-27 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 22:58 [PATCH 19/29] s3c-fb: use display information in info not in var for panning Laurent Pinchart
2011-05-27 0:45 ` 한진구 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12589456.8031306457158097.JavaMail.weblogic@epml08 \
--to=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).