* [PATCH 5/5] OMAP3EVM: Kconfig option added for selection between SVIDEO and CVBS @ 2009-12-17 15:31 hvaibhav 2009-12-17 16:42 ` [PATCH 5/5] OMAP3EVM: Kconfig option added for selection Randy Dunlap 2009-12-22 12:08 ` Tomi Valkeinen 0 siblings, 2 replies; 5+ messages in thread From: hvaibhav @ 2009-12-17 15:31 UTC (permalink / raw) To: tomi.valkeinen Cc: linux-omap, linux-fbdev-devel, linux-fbdev, Vaibhav Hiremath From: Vaibhav Hiremath <hvaibhav@ti.com> Config option added to arch/arm/plat-omap/Kconfig for selection of S-Video and Composite output interfaces. The default configuration would be S-Video. Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> --- arch/arm/mach-omap2/board-omap3evm.c | 4 ++++ drivers/video/omap2/dss/Kconfig | 15 +++++++++++++++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c index e615254..549e58e 100644 --- a/arch/arm/mach-omap2/board-omap3evm.c +++ b/arch/arm/mach-omap2/board-omap3evm.c @@ -275,7 +275,11 @@ static struct omap_dss_device omap3_evm_tv_device = { .name = "tv", .driver_name = "venc", .type = OMAP_DISPLAY_TYPE_VENC, +#if defined(CONFIG_OMAP2_VENC_OUT_TYPE_SVIDEO) .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO, +#elif defined(CONFIG_OMAP2_VENC_OUT_TYPE_COMPOSITE) + .u.venc.type = OMAP_DSS_VENC_TYPE_COMPOSITE, +#endif .platform_enable = omap3_evm_enable_tv, .platform_disable = omap3_evm_disable_tv, }; diff --git a/drivers/video/omap2/dss/Kconfig b/drivers/video/omap2/dss/Kconfig index 71d8dec..5b7a8bc 100644 --- a/drivers/video/omap2/dss/Kconfig +++ b/drivers/video/omap2/dss/Kconfig @@ -36,6 +36,21 @@ config OMAP2_DSS_VENC default y help OMAP Video Encoder support. +choice + prompt OMAP2_VENC_OUT_TYPE + depends on OMAP2_DSS_VENC + default OMAP2_VENC_OUT_TYPE_SVIDEO + +config OMAP2_VENC_OUT_TYPE_SVIDEO + bool "Use S-Video output interface" + help + Select this option if you want to choose TV out over S-Video + +config OMAP2_VENC_OUT_TYPE_COMPOSITE + bool "Use Composite output interface" + help + Select this option if you want to choose TV out over Composite +endchoice config OMAP2_DSS_SDI bool "SDI support" -- 1.6.2.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 5/5] OMAP3EVM: Kconfig option added for selection 2009-12-17 15:31 [PATCH 5/5] OMAP3EVM: Kconfig option added for selection between SVIDEO and CVBS hvaibhav @ 2009-12-17 16:42 ` Randy Dunlap 2009-12-18 4:25 ` Hiremath, Vaibhav 2009-12-22 12:08 ` Tomi Valkeinen 1 sibling, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2009-12-17 16:42 UTC (permalink / raw) To: hvaibhav; +Cc: tomi.valkeinen, linux-omap, linux-fbdev-devel, linux-fbdev On Thu, 17 Dec 2009 20:49:36 +0530 hvaibhav@ti.com wrote: > From: Vaibhav Hiremath <hvaibhav@ti.com> > > Config option added to arch/arm/plat-omap/Kconfig for selection > of S-Video and Composite output interfaces. The default configuration would > be S-Video. > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > --- > arch/arm/mach-omap2/board-omap3evm.c | 4 ++++ > drivers/video/omap2/dss/Kconfig | 15 +++++++++++++++ > 2 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c > index e615254..549e58e 100644 > --- a/arch/arm/mach-omap2/board-omap3evm.c > +++ b/arch/arm/mach-omap2/board-omap3evm.c > @@ -275,7 +275,11 @@ static struct omap_dss_device omap3_evm_tv_device = { > .name = "tv", > .driver_name = "venc", > .type = OMAP_DISPLAY_TYPE_VENC, > +#if defined(CONFIG_OMAP2_VENC_OUT_TYPE_SVIDEO) > .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO, > +#elif defined(CONFIG_OMAP2_VENC_OUT_TYPE_COMPOSITE) > + .u.venc.type = OMAP_DSS_VENC_TYPE_COMPOSITE, .u or .phy ? > +#endif > .platform_enable = omap3_evm_enable_tv, > .platform_disable = omap3_evm_disable_tv, > }; --- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 5/5] OMAP3EVM: Kconfig option added for selection 2009-12-17 16:42 ` [PATCH 5/5] OMAP3EVM: Kconfig option added for selection Randy Dunlap @ 2009-12-18 4:25 ` Hiremath, Vaibhav 0 siblings, 0 replies; 5+ messages in thread From: Hiremath, Vaibhav @ 2009-12-18 4:25 UTC (permalink / raw) To: Randy Dunlap Cc: tomi.valkeinen@nokia.com, linux-omap@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net, linux-fbdev@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 1902 bytes --] > -----Original Message----- > From: Randy Dunlap [mailto:randy.dunlap@oracle.com] > Sent: Thursday, December 17, 2009 10:13 PM > To: Hiremath, Vaibhav > Cc: tomi.valkeinen@nokia.com; linux-omap@vger.kernel.org; linux- > fbdev-devel@lists.sourceforge.net; linux-fbdev@vger.kernel.org > Subject: Re: [PATCH 5/5] OMAP3EVM: Kconfig option added for > selection between SVIDEO and CVBS > > On Thu, 17 Dec 2009 20:49:36 +0530 hvaibhav@ti.com wrote: > > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > > > Config option added to arch/arm/plat-omap/Kconfig for selection > > of S-Video and Composite output interfaces. The default > configuration would > > be S-Video. > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > --- > > arch/arm/mach-omap2/board-omap3evm.c | 4 ++++ > > drivers/video/omap2/dss/Kconfig | 15 +++++++++++++++ > > 2 files changed, 19 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach- > omap2/board-omap3evm.c > > index e615254..549e58e 100644 > > --- a/arch/arm/mach-omap2/board-omap3evm.c > > +++ b/arch/arm/mach-omap2/board-omap3evm.c > > @@ -275,7 +275,11 @@ static struct omap_dss_device > omap3_evm_tv_device = { > > .name = "tv", > > .driver_name = "venc", > > .type = OMAP_DISPLAY_TYPE_VENC, > > +#if defined(CONFIG_OMAP2_VENC_OUT_TYPE_SVIDEO) > > .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO, > > +#elif defined(CONFIG_OMAP2_VENC_OUT_TYPE_COMPOSITE) > > + .u.venc.type = OMAP_DSS_VENC_TYPE_COMPOSITE, > > .u or .phy ? > [Hiremath, Vaibhav] Good catch; and this must be last minute cleanup of patch for submission. I have attached updated/fixed version here with this mail. Thanks, Vaibhav > > +#endif > > .platform_enable = omap3_evm_enable_tv, > > .platform_disable = omap3_evm_disable_tv, > > }; > > > > --- > ~Randy [-- Attachment #2: OMAP-DSS2-Kconfig-option-added-for-selection-betwee.patch --] [-- Type: application/octet-stream, Size: 2020 bytes --] From 1ce4ede36b0e84907f1bd4a823d0b6661dead46f Mon Sep 17 00:00:00 2001 From: Vaibhav Hiremath <hvaibhav@ti.com> Date: Wed, 25 Nov 2009 19:31:54 +0530 Subject: [PATCH] OMAP:DSS2: Kconfig option added for selection between SVIDEO and CVBS Config option added to arch/arm/plat-omap/Kconfig for selection of S-Video and Composite output interfaces. The default configuration would be S-Video. Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> --- arch/arm/mach-omap2/board-omap3evm.c | 4 ++++ drivers/video/omap2/dss/Kconfig | 15 +++++++++++++++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c index e615254..9d27610 100644 --- a/arch/arm/mach-omap2/board-omap3evm.c +++ b/arch/arm/mach-omap2/board-omap3evm.c @@ -275,7 +275,11 @@ static struct omap_dss_device omap3_evm_tv_device = { .name = "tv", .driver_name = "venc", .type = OMAP_DISPLAY_TYPE_VENC, +#if defined(CONFIG_OMAP2_VENC_OUT_TYPE_SVIDEO) .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO, +#elif defined(CONFIG_OMAP2_VENC_OUT_TYPE_COMPOSITE) + .phy.venc.type = OMAP_DSS_VENC_TYPE_COMPOSITE, +#endif .platform_enable = omap3_evm_enable_tv, .platform_disable = omap3_evm_disable_tv, }; diff --git a/drivers/video/omap2/dss/Kconfig b/drivers/video/omap2/dss/Kconfig index 71d8dec..5b7a8bc 100644 --- a/drivers/video/omap2/dss/Kconfig +++ b/drivers/video/omap2/dss/Kconfig @@ -36,6 +36,21 @@ config OMAP2_DSS_VENC default y help OMAP Video Encoder support. +choice + prompt OMAP2_VENC_OUT_TYPE + depends on OMAP2_DSS_VENC + default OMAP2_VENC_OUT_TYPE_SVIDEO + +config OMAP2_VENC_OUT_TYPE_SVIDEO + bool "Use S-Video output interface" + help + Select this option if you want to choose TV out over S-Video + +config OMAP2_VENC_OUT_TYPE_COMPOSITE + bool "Use Composite output interface" + help + Select this option if you want to choose TV out over Composite +endchoice config OMAP2_DSS_SDI bool "SDI support" -- 1.6.2.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 5/5] OMAP3EVM: Kconfig option added for selection 2009-12-17 15:31 [PATCH 5/5] OMAP3EVM: Kconfig option added for selection between SVIDEO and CVBS hvaibhav 2009-12-17 16:42 ` [PATCH 5/5] OMAP3EVM: Kconfig option added for selection Randy Dunlap @ 2009-12-22 12:08 ` Tomi Valkeinen 2009-12-23 15:24 ` Hiremath, Vaibhav 1 sibling, 1 reply; 5+ messages in thread From: Tomi Valkeinen @ 2009-12-22 12:08 UTC (permalink / raw) To: ext hvaibhav@ti.com Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org Hi, On Thu, 2009-12-17 at 16:19 +0100, ext hvaibhav@ti.com wrote: > From: Vaibhav Hiremath <hvaibhav@ti.com> > > Config option added to arch/arm/plat-omap/Kconfig for selection > of S-Video and Composite output interfaces. The default configuration would > be S-Video. I don't think this is correct. You've made a board spesific Kconfig option, but it's under normal DSS options. Normally the type of the analog tv-out is a board hardware feature. And so I don't see need for a generic kernel option to set the type, as it should be just defined in the board file. Are there many boards with both outputs? If there's just one or two development boards that have both outputs, I think it's better to handle it with board spesific code. Tomi > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > --- > arch/arm/mach-omap2/board-omap3evm.c | 4 ++++ > drivers/video/omap2/dss/Kconfig | 15 +++++++++++++++ > 2 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c > index e615254..549e58e 100644 > --- a/arch/arm/mach-omap2/board-omap3evm.c > +++ b/arch/arm/mach-omap2/board-omap3evm.c > @@ -275,7 +275,11 @@ static struct omap_dss_device omap3_evm_tv_device = { > .name = "tv", > .driver_name = "venc", > .type = OMAP_DISPLAY_TYPE_VENC, > +#if defined(CONFIG_OMAP2_VENC_OUT_TYPE_SVIDEO) > .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO, > +#elif defined(CONFIG_OMAP2_VENC_OUT_TYPE_COMPOSITE) > + .u.venc.type = OMAP_DSS_VENC_TYPE_COMPOSITE, > +#endif > .platform_enable = omap3_evm_enable_tv, > .platform_disable = omap3_evm_disable_tv, > }; > diff --git a/drivers/video/omap2/dss/Kconfig b/drivers/video/omap2/dss/Kconfig > index 71d8dec..5b7a8bc 100644 > --- a/drivers/video/omap2/dss/Kconfig > +++ b/drivers/video/omap2/dss/Kconfig > @@ -36,6 +36,21 @@ config OMAP2_DSS_VENC > default y > help > OMAP Video Encoder support. > +choice > + prompt OMAP2_VENC_OUT_TYPE > + depends on OMAP2_DSS_VENC > + default OMAP2_VENC_OUT_TYPE_SVIDEO > + > +config OMAP2_VENC_OUT_TYPE_SVIDEO > + bool "Use S-Video output interface" > + help > + Select this option if you want to choose TV out over S-Video > + > +config OMAP2_VENC_OUT_TYPE_COMPOSITE > + bool "Use Composite output interface" > + help > + Select this option if you want to choose TV out over Composite > +endchoice > > config OMAP2_DSS_SDI > bool "SDI support" ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 5/5] OMAP3EVM: Kconfig option added for selection 2009-12-22 12:08 ` Tomi Valkeinen @ 2009-12-23 15:24 ` Hiremath, Vaibhav 0 siblings, 0 replies; 5+ messages in thread From: Hiremath, Vaibhav @ 2009-12-23 15:24 UTC (permalink / raw) To: Tomi Valkeinen; +Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org > -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com] > Sent: Tuesday, December 22, 2009 5:39 PM > To: Hiremath, Vaibhav > Cc: linux-omap@vger.kernel.org; linux-fbdev@vger.kernel.org > Subject: Re: [PATCH 5/5] OMAP3EVM: Kconfig option added for > selection between SVIDEO and CVBS > > Hi, > > On Thu, 2009-12-17 at 16:19 +0100, ext hvaibhav@ti.com wrote: > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > > > Config option added to arch/arm/plat-omap/Kconfig for selection > > of S-Video and Composite output interfaces. The default > configuration would > > be S-Video. > > I don't think this is correct. You've made a board spesific Kconfig > option, but it's under normal DSS options. > [Hiremath, Vaibhav] Frankly, I wanted to initiate the discussion on this, so that I will have some inputs here - Actually we should not have Kconfig options at all for such things but should be configurable from bootargs like other configuration along with SYSFS interface. SYSFS - /sys/devices/platform/omapdss/display1/output Bootargs - Omapdss_def_disp=tv:<output> Where, Output = cvbs or svideo > Normally the type of the analog tv-out is a board hardware feature. > And > so I don't see need for a generic kernel option to set the type, as > it > should be just defined in the board file. > > Are there many boards with both outputs? If there's just one or two > development boards that have both outputs, I think it's better to > handle > it with board spesific code. > [Hiremath, Vaibhav] OMAP3EVM supports both the outputs and that's where we required some configurable option to choose between. Thanks, Vaibhav > Tomi > > > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > --- > > arch/arm/mach-omap2/board-omap3evm.c | 4 ++++ > > drivers/video/omap2/dss/Kconfig | 15 +++++++++++++++ > > 2 files changed, 19 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach- > omap2/board-omap3evm.c > > index e615254..549e58e 100644 > > --- a/arch/arm/mach-omap2/board-omap3evm.c > > +++ b/arch/arm/mach-omap2/board-omap3evm.c > > @@ -275,7 +275,11 @@ static struct omap_dss_device > omap3_evm_tv_device = { > > .name = "tv", > > .driver_name = "venc", > > .type = OMAP_DISPLAY_TYPE_VENC, > > +#if defined(CONFIG_OMAP2_VENC_OUT_TYPE_SVIDEO) > > .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO, > > +#elif defined(CONFIG_OMAP2_VENC_OUT_TYPE_COMPOSITE) > > + .u.venc.type = OMAP_DSS_VENC_TYPE_COMPOSITE, > > +#endif > > .platform_enable = omap3_evm_enable_tv, > > .platform_disable = omap3_evm_disable_tv, > > }; > > diff --git a/drivers/video/omap2/dss/Kconfig > b/drivers/video/omap2/dss/Kconfig > > index 71d8dec..5b7a8bc 100644 > > --- a/drivers/video/omap2/dss/Kconfig > > +++ b/drivers/video/omap2/dss/Kconfig > > @@ -36,6 +36,21 @@ config OMAP2_DSS_VENC > > default y > > help > > OMAP Video Encoder support. > > +choice > > + prompt OMAP2_VENC_OUT_TYPE > > + depends on OMAP2_DSS_VENC > > + default OMAP2_VENC_OUT_TYPE_SVIDEO > > + > > +config OMAP2_VENC_OUT_TYPE_SVIDEO > > + bool "Use S-Video output interface" > > + help > > + Select this option if you want to choose TV out over S-Video > > + > > +config OMAP2_VENC_OUT_TYPE_COMPOSITE > > + bool "Use Composite output interface" > > + help > > + Select this option if you want to choose TV out over > Composite > > +endchoice > > > > config OMAP2_DSS_SDI > > bool "SDI support" > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-12-23 15:24 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-12-17 15:31 [PATCH 5/5] OMAP3EVM: Kconfig option added for selection between SVIDEO and CVBS hvaibhav 2009-12-17 16:42 ` [PATCH 5/5] OMAP3EVM: Kconfig option added for selection Randy Dunlap 2009-12-18 4:25 ` Hiremath, Vaibhav 2009-12-22 12:08 ` Tomi Valkeinen 2009-12-23 15:24 ` Hiremath, Vaibhav
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).