From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: "ext hvaibhav@ti.com" <hvaibhav@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev-devel@lists.sourceforge.net"
<linux-fbdev-devel@lists.sourceforge.net>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed
Date: Tue, 22 Dec 2009 11:59:14 +0000 [thread overview]
Message-ID: <1261483154.2108.86.camel@tubuntu.research.nokia.com> (raw)
In-Reply-To: <1261063105-19874-1-git-send-email-hvaibhav@ti.com>
Hi,
On Thu, 2009-12-17 at 16:18 +0100, ext hvaibhav@ti.com wrote:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
>
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Which warning does this fix? I don't get any compiler warnings.
Can you change the name of the patch to a more standard one?
Tomi
> ---
> drivers/video/omap2/dss/core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
> index 29497a0..2fabaf2 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -124,6 +124,7 @@ static void restore_all_ctx(void)
> dss_clk_disable_all_no_ctx();
> }
>
> +#if defined(CONFIG_DEBUG_FS) && defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT)
> /* CLOCKS */
> static void core_dump_clocks(struct seq_file *s)
> {
> @@ -149,6 +150,7 @@ static void core_dump_clocks(struct seq_file *s)
> clocks[i]->usecount);
> }
> }
> +#endif /* defined(CONFIG_DEBUG_FS) && defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT) */
>
> static int dss_get_clock(struct clk **clock, const char *clk_name)
> {
next prev parent reply other threads:[~2009-12-22 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 15:30 [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed under DEBUG_FS hvaibhav
2009-12-22 11:59 ` Tomi Valkeinen [this message]
2009-12-23 16:46 ` [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed Hiremath, Vaibhav
2010-01-04 9:42 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261483154.2108.86.camel@tubuntu.research.nokia.com \
--to=tomi.valkeinen@nokia.com \
--cc=hvaibhav@ti.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).