[PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed under DEBUG_FS

[PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed under DEBUG_FS

[hvaibhav]

From: Vaibhav Hiremath <hvaibhav@ti.com>


Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
---
 drivers/video/omap2/dss/core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
index 29497a0..2fabaf2 100644
--- a/drivers/video/omap2/dss/core.c
+++ b/drivers/video/omap2/dss/core.c
@@ -124,6 +124,7 @@ static void restore_all_ctx(void)
 	dss_clk_disable_all_no_ctx();
 }
 
+#if defined(CONFIG_DEBUG_FS) && defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT)
 /* CLOCKS */
 static void core_dump_clocks(struct seq_file *s)
 {
@@ -149,6 +150,7 @@ static void core_dump_clocks(struct seq_file *s)
 				clocks[i]->usecount);
 	}
 }
+#endif /* defined(CONFIG_DEBUG_FS) && defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT) */
 
 static int dss_get_clock(struct clk **clock, const char *clk_name)
 {
-- 
1.6.2.4

Re: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed

[Tomi Valkeinen]

Hi,

On Thu, 2009-12-17 at 16:18 +0100, ext hvaibhav@ti.com wrote:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
> 
> 
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>

Which warning does this fix? I don't get any compiler warnings.

Can you change the name of the patch to a more standard one?

 Tomi

> ---
>  drivers/video/omap2/dss/core.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
> index 29497a0..2fabaf2 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -124,6 +124,7 @@ static void restore_all_ctx(void)
>  	dss_clk_disable_all_no_ctx();
>  }
>  
> +#if defined(CONFIG_DEBUG_FS) && defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT)
>  /* CLOCKS */
>  static void core_dump_clocks(struct seq_file *s)
>  {
> @@ -149,6 +150,7 @@ static void core_dump_clocks(struct seq_file *s)
>  				clocks[i]->usecount);
>  	}
>  }
> +#endif /* defined(CONFIG_DEBUG_FS) && defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT) */
>  
>  static int dss_get_clock(struct clk **clock, const char *clk_name)
>  {

RE: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: Tuesday, December 22, 2009 5:29 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; linux-fbdev-
> devel@lists.sourceforge.net; linux-fbdev@vger.kernel.org
> Subject: Re: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks
> enclosed under DEBUG_FS
> 
> Hi,
> 
> On Thu, 2009-12-17 at 16:18 +0100, ext hvaibhav@ti.com wrote:
> > From: Vaibhav Hiremath <hvaibhav@ti.com>
> >
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> 
> Which warning does this fix? I don't get any compiler warnings.
> 
[Hiremath, Vaibhav] Below is the log - 


  CC      drivers/video/omap2/dss/core.o
drivers/video/omap2/dss/core.c:129: warning: 'core_dump_clocks' defined but not used
  CC      drivers/video/omap2/dss/dss.o


> Can you change the name of the patch to a more standard one?
> 
[Hiremath, Vaibhav] Ok, will do that and resubmit. I believe only prefix "OMAP" should do.

Thanks,
Vaibhav

>  Tomi
> 
> > ---
> >  drivers/video/omap2/dss/core.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/video/omap2/dss/core.c
> b/drivers/video/omap2/dss/core.c
> > index 29497a0..2fabaf2 100644
> > --- a/drivers/video/omap2/dss/core.c
> > +++ b/drivers/video/omap2/dss/core.c
> > @@ -124,6 +124,7 @@ static void restore_all_ctx(void)
> >  	dss_clk_disable_all_no_ctx();
> >  }
> >
> > +#if defined(CONFIG_DEBUG_FS) &&
> defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT)
> >  /* CLOCKS */
> >  static void core_dump_clocks(struct seq_file *s)
> >  {
> > @@ -149,6 +150,7 @@ static void core_dump_clocks(struct seq_file
> *s)
> >  				clocks[i]->usecount);
> >  	}
> >  }
> > +#endif /* defined(CONFIG_DEBUG_FS) &&
> defined(CONFIG_OMAP2_DSS_DEBUG_SUPPORT) */
> >
> >  static int dss_get_clock(struct clk **clock, const char
> *clk_name)
> >  {
> 

RE: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed

[Tomi Valkeinen]

On Wed, 2009-12-23 at 17:34 +0100, ext Hiremath, Vaibhav wrote:
> > -----Original Message-----
> > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> > Sent: Tuesday, December 22, 2009 5:29 PM
> > To: Hiremath, Vaibhav
> > Cc: linux-omap@vger.kernel.org; linux-fbdev-
> > devel@lists.sourceforge.net; linux-fbdev@vger.kernel.org
> > Subject: Re: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks
> > enclosed under DEBUG_FS
> > 
> > Hi,
> > 
> > On Thu, 2009-12-17 at 16:18 +0100, ext hvaibhav@ti.com wrote:
> > > From: Vaibhav Hiremath <hvaibhav@ti.com>
> > >
> > >
> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > 
> > Which warning does this fix? I don't get any compiler warnings.
> > 
> [Hiremath, Vaibhav] Below is the log - 
> 
> 
>   CC      drivers/video/omap2/dss/core.o
> drivers/video/omap2/dss/core.c:129: warning: 'core_dump_clocks' defined but not used
>   CC      drivers/video/omap2/dss/dss.o

Ok. For some reason my compiler doesn't warn about that.

> 
> > Can you change the name of the patch to a more standard one?
> > 
> [Hiremath, Vaibhav] Ok, will do that and resubmit. I believe only prefix "OMAP" should do.

Something like:

OMAP: DSS2: fix compile warning

 Tomi