From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Mon, 04 Jan 2010 09:42:59 +0000 Subject: RE: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks enclosed Message-Id: <1262598179.2381.20.camel@tubuntu.research.nokia.com> List-Id: References: <1261063105-19874-1-git-send-email-hvaibhav@ti.com> <1261483154.2108.86.camel@tubuntu.research.nokia.com> <19F8576C6E063C45BE387C64729E7394044A277589@dbde02.ent.ti.com> In-Reply-To: <19F8576C6E063C45BE387C64729E7394044A277589@dbde02.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "ext Hiremath, Vaibhav" Cc: "linux-omap@vger.kernel.org" , "linux-fbdev@vger.kernel.org" On Wed, 2009-12-23 at 17:34 +0100, ext Hiremath, Vaibhav wrote: > > -----Original Message----- > > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com] > > Sent: Tuesday, December 22, 2009 5:29 PM > > To: Hiremath, Vaibhav > > Cc: linux-omap@vger.kernel.org; linux-fbdev- > > devel@lists.sourceforge.net; linux-fbdev@vger.kernel.org > > Subject: Re: [PATCH 1/5] dss2-core:Warning Fix: core_dump_clocks > > enclosed under DEBUG_FS > > > > Hi, > > > > On Thu, 2009-12-17 at 16:18 +0100, ext hvaibhav@ti.com wrote: > > > From: Vaibhav Hiremath > > > > > > > > > Signed-off-by: Vaibhav Hiremath > > > > Which warning does this fix? I don't get any compiler warnings. > > > [Hiremath, Vaibhav] Below is the log - > > > CC drivers/video/omap2/dss/core.o > drivers/video/omap2/dss/core.c:129: warning: 'core_dump_clocks' defined but not used > CC drivers/video/omap2/dss/dss.o Ok. For some reason my compiler doesn't warn about that. > > > Can you change the name of the patch to a more standard one? > > > [Hiremath, Vaibhav] Ok, will do that and resubmit. I believe only prefix "OMAP" should do. Something like: OMAP: DSS2: fix compile warning Tomi