RE: [PATCH 01/15] OMAP: DSS2: DSI: fix VC channels in send_short

[Tomi Valkeinen <tomi.valkeinen@nokia.com>]

On Fri, 2010-01-08 at 14:29 +0100, ext Aguirre, Sergio wrote:
> Tomi,
> 
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of Tomi Valkeinen
> > Sent: Friday, January 08, 2010 7:23 AM
> > To: linux-omap@vger.kernel.org; linux-fbdev@vger.kernel.org
> > Cc: Tomi Valkeinen
> > Subject: [PATCH 01/15] OMAP: DSS2: DSI: fix VC channels in send_short and
> > send_null
> > 
> > - dsi_vc_send_short() needs to use dest_per for the peripheral id
> > - dsi_vc_send_null() was always using channel id 0
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > ---
> >  drivers/video/omap2/dss/dsi.c |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c
> > index 5936487..c37bc5b 100644
> > --- a/drivers/video/omap2/dss/dsi.c
> > +++ b/drivers/video/omap2/dss/dsi.c
> > @@ -1999,7 +1999,8 @@ static int dsi_vc_send_short(int channel, u8
> > data_type, u16 data, u8 ecc)
> >  		return -EINVAL;
> >  	}
> > 
> > -	data_id = data_type | channel << 6;
> > +	/* data_id = data_type | channel << 6; */
> 
> Why do you need this old line commented?

Ah. I don't =). Thanks.

 Tomi