From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 18 Jan 2010 19:59:30 +0000 Subject: Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c Message-Id: <1263844770.26846.134.camel@Joe-Laptop.home> List-Id: References: <201001181934.49519.PeterHuewe@gmx.de> <1263842269.26846.122.camel@Joe-Laptop.home> <201001182027.29805.PeterHuewe@gmx.de> In-Reply-To: <201001182027.29805.PeterHuewe@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Peter =?ISO-8859-1?Q?H=FCwe?= Cc: Petr Vandrovec , Andrew Morton , Jean Delvare , Krzysztof Helt , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, 2010-01-18 at 20:27 +0100, Peter H=C3=BCwe wrote: > the reason behind this change was that spaces and tabs were mixed for=20 > indention.=20 Checkpatch isn't gospel and isn't always right. There should be room for taste preference here and I think whatever Petr V's is should prevail. > How about this indention? Would this be better? Well, I don't think so, but others will have different opinions.