Re: [PATCH 2/2] OMAP: DSS2: OMAPFB: implement

[Tomi Valkeinen <tomi.valkeinen@nokia.com>]

On Fri, 2010-02-05 at 00:05 +0100, ext Ville Syrjälä wrote:
> On Thu, Feb 04, 2010 at 05:31:26PM +0200, Tomi Valkeinen wrote:
> > Previously the only place to get the size of the display was from the
> > DSS's sysfs interface, making, for example, configuring overlays and doing
> > updates on manual displays more difficult.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > ---
> >  drivers/video/omap2/omapfb/omapfb-ioctl.c |   18 ++++++++++++++++++
> >  include/linux/omapfb.h                    |    7 +++++++
> >  2 files changed, 25 insertions(+), 0 deletions(-)
> > 
> <snip>
> > @@ -216,6 +217,12 @@ struct omapfb_tearsync_info {
> >  	__u16 reserved2;
> >  };
> >  
> > +struct omapfb_display_info {
> > +	__u16 width;
> > +	__u16 height;
> 
> How about adding the physical display size here as well? I suppose
> mm is the standard unit for such things but for small displays more
> accuracy might be nice.

That can be read from framebuffer's var struct. But I could add it here
also for completeness. Perhaps also some other display related info,
like capabilities.

 Tomi