From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: "Quadros Roger (Nokia-D/Helsinki)" <roger.quadros@nokia.com>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RFC][PATCH 2/3] OMAP: DSS2: Prevent recursive Panel
Date: Mon, 15 Mar 2010 09:52:46 +0000 [thread overview]
Message-ID: <1268646766.2417.37.camel@tubuntu.research.nokia.com> (raw)
In-Reply-To: <1268645546.2417.15.camel@tubuntu.research.nokia.com>
On Mon, 2010-03-15 at 10:32 +0100, Tomi Valkeinen wrote:
> On Fri, 2010-03-12 at 16:27 +0100, Quadros Roger (Nokia-D/Helsinki)
> wrote:
> > From: Roger Quadros <roger.quadros@nokia.com>
> >
> > Panel enable/disable is now done inside display manager,
> > so don't need to do it again.
> >
>
> This looks correct, thanks.
Actually, I take my word back =).
This patch leaves the err3 label there, and you remove it in the next
patch. It should be removed in this same patch.
And the patch description is a bit strange. I think it should be
something like:
"Panel enable/disable is now done via the panel driver, so we should not
call the panel driver again."
Tomi
next prev parent reply other threads:[~2010-03-15 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 15:27 [RFC][PATCH 0/3] OMAP: DSS2: Allow us to use SDI Roger Quadros
2010-03-12 15:27 ` [RFC][PATCH 1/3] OMAP: DSS2: Do regulator stuff in dpi_init_display() Roger Quadros
2010-03-12 15:27 ` [RFC][PATCH 2/3] OMAP: DSS2: Prevent recursive Panel Enable/Disable calls from SDI Roger Quadros
2010-03-12 15:27 ` [RFC][PATCH 3/3] OMAP: DSS2: Use vdds_sdi regulator supply in SDI Roger Quadros
2010-03-15 9:53 ` [RFC][PATCH 3/3] OMAP: DSS2: Use vdds_sdi regulator supply in Tomi Valkeinen
2010-03-15 11:26 ` Roger Quadros
2010-03-15 11:32 ` Tomi Valkeinen
2010-03-15 9:32 ` [RFC][PATCH 2/3] OMAP: DSS2: Prevent recursive Panel Tomi Valkeinen
2010-03-15 9:52 ` Tomi Valkeinen [this message]
2010-03-15 9:30 ` [RFC][PATCH 1/3] OMAP: DSS2: Do regulator stuff in Tomi Valkeinen
2010-03-15 9:57 ` [RFC][PATCH 1/3] OMAP: DSS2: Do regulator stuff in dpi_init_display() Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268646766.2417.37.camel@tubuntu.research.nokia.com \
--to=tomi.valkeinen@nokia.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=roger.quadros@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).