From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Mon, 15 Mar 2010 09:52:46 +0000 Subject: Re: [RFC][PATCH 2/3] OMAP: DSS2: Prevent recursive Panel Message-Id: <1268646766.2417.37.camel@tubuntu.research.nokia.com> List-Id: References: <1268407644-31230-1-git-send-email-roger.quadros@nokia.com> <1268407644-31230-2-git-send-email-roger.quadros@nokia.com> <1268407644-31230-3-git-send-email-roger.quadros@nokia.com> <1268645546.2417.15.camel@tubuntu.research.nokia.com> In-Reply-To: <1268645546.2417.15.camel@tubuntu.research.nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Quadros Roger (Nokia-D/Helsinki)" Cc: "linux-fbdev@vger.kernel.org" , "linux-omap@vger.kernel.org" On Mon, 2010-03-15 at 10:32 +0100, Tomi Valkeinen wrote: > On Fri, 2010-03-12 at 16:27 +0100, Quadros Roger (Nokia-D/Helsinki) > wrote: > > From: Roger Quadros > > > > Panel enable/disable is now done inside display manager, > > so don't need to do it again. > > > > This looks correct, thanks. Actually, I take my word back =). This patch leaves the err3 label there, and you remove it in the next patch. It should be removed in this same patch. And the patch description is a bit strange. I think it should be something like: "Panel enable/disable is now done via the panel driver, so we should not call the panel driver again." Tomi