* [PATCH 23/24] video/matrox: fix dangling pointers [not found] <1269094385-16114-1-git-send-email-w.sang@pengutronix.de> @ 2010-03-20 14:13 ` Wolfram Sang [not found] ` <1269094385-16114-24-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Wolfram Sang @ 2010-03-20 14:13 UTC (permalink / raw) To: kernel-janitors Cc: linux-i2c, linux-kernel, Wolfram Sang, Petr Vandrovec, linux-fbdev Fix I2C-drivers which missed setting clientdata to NULL before freeing the structure it points to. Also fix drivers which do this _after_ the structure was freed already. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Cc: Petr Vandrovec <vandrove@vc.cvut.cz> --- Found using coccinelle, then reviewed. Full patchset is available via kernel-janitors, linux-i2c, and LKML. --- drivers/video/matrox/matroxfb_maven.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c index 91af915..e7b0ec3 100644 --- a/drivers/video/matrox/matroxfb_maven.c +++ b/drivers/video/matrox/matroxfb_maven.c @@ -1254,6 +1254,7 @@ static int maven_probe(struct i2c_client *client, goto ERROR4; return 0; ERROR4:; + i2c_set_clientdata(client, NULL); kfree(data); ERROR0:; return err; -- 1.7.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <1269094385-16114-24-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH 23/24] video/matrox: fix dangling pointers [not found] ` <1269094385-16114-24-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2010-04-05 14:04 ` James Simmons 0 siblings, 0 replies; 2+ messages in thread From: James Simmons @ 2010-04-05 14:04 UTC (permalink / raw) To: Wolfram Sang Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA, Linux Kernel Mailing List, Petr Vandrovec, Linux Fbdev development list, Andrew Morton On Sat, 20 Mar 2010, Wolfram Sang wrote: > Fix I2C-drivers which missed setting clientdata to NULL before freeing the > structure it points to. Also fix drivers which do this _after_ the structure > was freed already. > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > Cc: Petr Vandrovec <vandrove@vc.cvut.cz> > --- Acked-by: James Simmons <jsimmons@infradead.org> > Found using coccinelle, then reviewed. Full patchset is available via > kernel-janitors, linux-i2c, and LKML. > --- > drivers/video/matrox/matroxfb_maven.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c > index 91af915..e7b0ec3 100644 > --- a/drivers/video/matrox/matroxfb_maven.c > +++ b/drivers/video/matrox/matroxfb_maven.c > @@ -1254,6 +1254,7 @@ static int maven_probe(struct i2c_client *client, > goto ERROR4; > return 0; > ERROR4:; > + i2c_set_clientdata(client, NULL); > kfree(data); > ERROR0:; > return err; > -- > 1.7.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-05 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1269094385-16114-1-git-send-email-w.sang@pengutronix.de>
2010-03-20 14:13 ` [PATCH 23/24] video/matrox: fix dangling pointers Wolfram Sang
[not found] ` <1269094385-16114-24-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-04-05 14:04 ` James Simmons
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).