From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Thadeu Lima de Souza Cascardo" <cascardo@holoscopio.com>,
"Baruch Siach" <baruch@tkos.co.il>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: [PATCH] fbdev: fix frame buffer devices menu
Date: Wed, 26 May 2010 17:54:37 +0000 [thread overview]
Message-ID: <1274896477-6832-1-git-send-email-cascardo@holoscopio.com> (raw)
Commit f601441916d1e19291d0b4f044b4a7551e2924d0 has inserted the symbol
HAVE_FB_IMX, which does not depend on FB after the menuconfig FB. This
breaks the menu, presenting most of the drivers outside of it, when
using menuconfig.
Moving the symbol to the start of the file, just like HAVE_FB_ATMEL,
fixes the problem without breaking it for iMX25 configurations (tested
with ARCH=arm, no build).
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
drivers/video/Kconfig | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 1e6fec4..3d94a14 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -8,6 +8,9 @@ menu "Graphics support"
config HAVE_FB_ATMEL
bool
+config HAVE_FB_IMX
+ bool
+
source "drivers/char/agp/Kconfig"
source "drivers/gpu/vga/Kconfig"
@@ -400,9 +403,6 @@ config FB_SA1100
If you plan to use the LCD display with your SA-1100 system, say
Y here.
-config HAVE_FB_IMX
- bool
-
config FB_IMX
tristate "Motorola i.MX LCD support"
depends on FB && (HAVE_FB_IMX || ARCH_MX1 || ARCH_MX2)
--
1.7.1
next reply other threads:[~2010-05-26 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 17:54 Thadeu Lima de Souza Cascardo [this message]
2010-05-26 19:02 ` [PATCH] fbdev: fix frame buffer devices menu
2010-05-27 4:03 ` Baruch Siach
2010-06-01 21:28 ` Andrew Morton
2010-06-01 21:41 ` Randy Dunlap
2010-06-02 4:34 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274896477-6832-1-git-send-email-cascardo@holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=baruch@tkos.co.il \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).