From: Guruswamy Senthilvadivu <svadivu@ti.com>
To: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
tony@atomide.com, tomi.valkeinen@nokia.com, hvaibhav@ti.com
Cc: Senthilvadivu Guruswamy <svadivu@ti.com>
Subject: [PATCH v3 3/3] DSS2 FB Allow usage of def_vrfb only for omap2,3
Date: Thu, 10 Jun 2010 11:35:57 +0000 [thread overview]
Message-ID: <1276169037-2598-3-git-send-email-svadivu@ti.com> (raw)
In-Reply-To: <1276169037-2598-2-git-send-email-svadivu@ti.com>
From: Senthilvadivu Guruswamy <svadivu@ti.com>
Changes since v2:
Added a check to warn the wrong usage of vrfb in non-vrfb omap devices.
Force def_vrfb to 0 for non omap2, omap3 devices
Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
---
drivers/video/omap2/omapfb/omapfb-main.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 4b4506d..0f79db8 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -2128,6 +2128,16 @@ static int omapfb_probe(struct platform_device *pdev)
goto err0;
}
+ /* TODO : Replace cpu check with omap_has_vrfb once HAS_FEATURE
+ * available for OMAP2 and OMAP3
+ */
+ if (def_vrfb && (!cpu_is_omap24xx()) && (!cpu_is_omap34xx())) {
+ def_vrfb = 0;
+ dev_warn(&pdev->dev, "VRFB is not in this device,"
+ "using DMA for rotation\n");
+ }
+
+
mutex_init(&fbdev->mtx);
fbdev->dev = &pdev->dev;
--
1.6.3.3
next prev parent reply other threads:[~2010-06-10 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 11:35 [PATCH v3 1/3] DSS2: Allow FB_OMAP2 to build without VRFB Guruswamy Senthilvadivu
2010-06-10 11:35 ` [PATCH v3 2/3] DSS2: make VRFB depends on OMAP2,3 Guruswamy Senthilvadivu
2010-06-10 11:35 ` Guruswamy Senthilvadivu [this message]
2010-06-15 10:15 ` [PATCH v3 3/3] DSS2 FB Allow usage of def_vrfb only for omap2,3 Guruswamy, Senthilvadivu
2010-06-17 9:03 ` [PATCH v3 2/3] DSS2: make VRFB depends on OMAP2,3 Tomi Valkeinen
2010-06-17 10:17 ` Guruswamy, Senthilvadivu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276169037-2598-3-git-send-email-svadivu@ti.com \
--to=svadivu@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).