linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 3/3] OMAP: DSS2: OMAPFB: Allow usage of def_vrfb only for omap2,3
  2010-06-22 11:57   ` [PATCH v4 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3 Guruswamy Senthilvadivu
@ 2010-06-22 11:57     ` Guruswamy Senthilvadivu
  0 siblings, 0 replies; 4+ messages in thread
From: Guruswamy Senthilvadivu @ 2010-06-22 11:57 UTC (permalink / raw)
  To: linux-omap, linux-fbdev, tony, tomi.valkeinen, hvaibhav
  Cc: Senthilvadivu Guruswamy

From: Senthilvadivu Guruswamy <svadivu@ti.com>

Force def_vrfb to 0 for non omap2, omap3 devices

Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
---
 drivers/video/omap2/omapfb/omapfb-main.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 4b4506d..0f79db8 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -2128,6 +2128,16 @@ static int omapfb_probe(struct platform_device *pdev)
 		goto err0;
 	}
 
+	/* TODO : Replace cpu check with omap_has_vrfb once HAS_FEATURE
+	*	 available for OMAP2 and OMAP3
+	*/
+	if (def_vrfb && (!cpu_is_omap24xx()) && (!cpu_is_omap34xx())) {
+		def_vrfb = 0;
+		dev_warn(&pdev->dev, "VRFB is not in this device,"
+				"using DMA for rotation\n");
+	}
+
+
 	mutex_init(&fbdev->mtx);
 
 	fbdev->dev = &pdev->dev;
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v4 1/3] OMAP: DSS2: OMAPFB: Allow FB_OMAP2 to build without VRFB
  2010-06-22 11:57 [PATCH v4 0/3] OMAP: DSS2: OMAPFB: Allow FB_OMAP2 to build without VRFB Guruswamy Senthilvadivu
@ 2010-06-22 11:57 ` Guruswamy Senthilvadivu
  2010-06-22 11:57   ` [PATCH v4 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3 Guruswamy Senthilvadivu
  0 siblings, 1 reply; 4+ messages in thread
From: Guruswamy Senthilvadivu @ 2010-06-22 11:57 UTC (permalink / raw)
  To: linux-omap, linux-fbdev, tony, tomi.valkeinen, hvaibhav
  Cc: Senthilvadivu Guruswamy

From: Senthilvadivu Guruswamy <svadivu@ti.com>

FB_OMAP2 can work without VRFB, but currently does not build. Fix this.

Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
---
 arch/arm/plat-omap/include/plat/vrfb.h |   16 ++++++++++++++++
 1 file changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-omap/include/plat/vrfb.h b/arch/arm/plat-omap/include/plat/vrfb.h
index d8a03ce..3792bde 100644
--- a/arch/arm/plat-omap/include/plat/vrfb.h
+++ b/arch/arm/plat-omap/include/plat/vrfb.h
@@ -35,6 +35,7 @@ struct vrfb {
 	bool yuv_mode;
 };
 
+#ifdef CONFIG_OMAP2_VRFB
 extern int omap_vrfb_request_ctx(struct vrfb *vrfb);
 extern void omap_vrfb_release_ctx(struct vrfb *vrfb);
 extern void omap_vrfb_adjust_size(u16 *width, u16 *height,
@@ -47,4 +48,19 @@ extern void omap_vrfb_setup(struct vrfb *vrfb, unsigned long paddr,
 extern int omap_vrfb_map_angle(struct vrfb *vrfb, u16 height, u8 rot);
 extern void omap_vrfb_restore_context(void);
 
+#else
+static inline int omap_vrfb_request_ctx(struct vrfb *vrfb) { return 0; }
+static inline void omap_vrfb_release_ctx(struct vrfb *vrfb) {}
+static inline void omap_vrfb_adjust_size(u16 *width, u16 *height,
+		u8 bytespp) {}
+static inline u32 omap_vrfb_min_phys_size(u16 width, u16 height, u8 bytespp)
+		{ return 0; }
+static inline u16 omap_vrfb_max_height(u32 phys_size, u16 width, u8 bytespp)
+		{ return 0; }
+static inline void omap_vrfb_setup(struct vrfb *vrfb, unsigned long paddr,
+		u16 width, u16 height, unsigned bytespp, bool yuv_mode) {}
+static inline int omap_vrfb_map_angle(struct vrfb *vrfb, u16 height, u8 rot)
+		{ return 0; }
+static inline void omap_vrfb_restore_context(void) {}
+#endif
 #endif /* __VRFB_H */
-- 
1.5.4.7


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v4 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3
  2010-06-22 11:57 ` [PATCH v4 1/3] " Guruswamy Senthilvadivu
@ 2010-06-22 11:57   ` Guruswamy Senthilvadivu
  2010-06-22 11:57     ` [PATCH v4 3/3] OMAP: DSS2: OMAPFB: Allow usage of def_vrfb only for omap2,3 Guruswamy Senthilvadivu
  0 siblings, 1 reply; 4+ messages in thread
From: Guruswamy Senthilvadivu @ 2010-06-22 11:57 UTC (permalink / raw)
  To: linux-omap, linux-fbdev, tony, tomi.valkeinen, hvaibhav
  Cc: Guruswamy Senthilvadivu

config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.

Signed-off-by: Senthilvadivu Guruswamy <svadivu@ti.com>
---
 drivers/video/omap2/omapfb/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/omap2/omapfb/Kconfig b/drivers/video/omap2/omapfb/Kconfig
index 43496d6..65149b2 100644
--- a/drivers/video/omap2/omapfb/Kconfig
+++ b/drivers/video/omap2/omapfb/Kconfig
@@ -3,7 +3,7 @@ menuconfig FB_OMAP2
         depends on FB && OMAP2_DSS
 
 	select OMAP2_VRAM
-	select OMAP2_VRFB
+	select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
         select FB_CFB_FILLRECT
         select FB_CFB_COPYAREA
         select FB_CFB_IMAGEBLIT
-- 
1.5.4.7


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v4 0/3] OMAP: DSS2: OMAPFB: Allow FB_OMAP2 to build without VRFB
@ 2010-06-22 11:57 Guruswamy Senthilvadivu
  2010-06-22 11:57 ` [PATCH v4 1/3] " Guruswamy Senthilvadivu
  0 siblings, 1 reply; 4+ messages in thread
From: Guruswamy Senthilvadivu @ 2010-06-22 11:57 UTC (permalink / raw)
  To: linux-omap, linux-fbdev, tony, tomi.valkeinen, hvaibhav
  Cc: Senthilvadivu Guruswamy

From: Senthilvadivu Guruswamy  <svadivu@ti.com>

Please ignore the previous v3 and consider v4.

The changelog till v4 are:
	- Address Multi-omap build issue
	- Added a check to warn the wrong usage of vrfb 
	in non-vrfb omap devices.
	- The patch subject is as per the naming conventions
	- patch 2/3 now has the changes in omap2/omapfb/Kconfig
	instead of omap2/Kconfig.  The functional effect remains
	the same, and the place of implementation is more appropriate.
	

Thanks,
Senthil

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-06-22 11:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-22 11:57 [PATCH v4 0/3] OMAP: DSS2: OMAPFB: Allow FB_OMAP2 to build without VRFB Guruswamy Senthilvadivu
2010-06-22 11:57 ` [PATCH v4 1/3] " Guruswamy Senthilvadivu
2010-06-22 11:57   ` [PATCH v4 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3 Guruswamy Senthilvadivu
2010-06-22 11:57     ` [PATCH v4 3/3] OMAP: DSS2: OMAPFB: Allow usage of def_vrfb only for omap2,3 Guruswamy Senthilvadivu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).