From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: ext Afzal Mohammed <lazfamam@gmail.com>
Cc: "Syrjala Ville (Nokia-D/Helsinki)" <ville.syrjala@nokia.com>,
"tj@kernel.org" <tj@kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] OMAP:DSS2:OMAPFB: Fix probe error path
Date: Thu, 01 Jul 2010 09:54:32 +0000 [thread overview]
Message-ID: <1277978072.2474.283.camel@tubuntu.research.nokia.com> (raw)
In-Reply-To: <1277907327-3443-1-git-send-email-lazfamam@gmail.com>
Hi,
On Wed, 2010-06-30 at 16:15 +0200, ext Afzal Mohammed wrote:
> If enabling fb0 fails in omapfb_create_framebuffers(), remove
> sysfs file before returning to probe. This is required to complete
> the cleanup in the above mentioned error case.
omapfb frees the resources in omapfb_free_resources(). I believe
removing sysfs should also be put into omapfb_free_resources() to be
consistent, and not as an explicit call like in this patch.
However, I'm not sure if some sysfs-allocated flag is needed for this to
work in all cases.
Tomi
next prev parent reply other threads:[~2010-07-01 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 14:27 [PATCH] OMAP:DSS2:OMAPFB: Fix probe error path Afzal Mohammed
2010-07-01 9:54 ` Tomi Valkeinen [this message]
2010-07-01 13:52 ` Afzal Mohammed
2010-07-01 13:52 ` Afzal Mohammed
2010-07-01 14:57 ` Tomi Valkeinen
2010-07-05 6:38 ` Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277978072.2474.283.camel@tubuntu.research.nokia.com \
--to=tomi.valkeinen@nokia.com \
--cc=lazfamam@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tj@kernel.org \
--cc=ville.syrjala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).