From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Thu, 01 Jul 2010 09:54:32 +0000 Subject: Re: [PATCH] OMAP:DSS2:OMAPFB: Fix probe error path Message-Id: <1277978072.2474.283.camel@tubuntu.research.nokia.com> List-Id: References: <1277907327-3443-1-git-send-email-lazfamam@gmail.com> In-Reply-To: <1277907327-3443-1-git-send-email-lazfamam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ext Afzal Mohammed Cc: "Syrjala Ville (Nokia-D/Helsinki)" , "tj@kernel.org" , "linux-omap@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Hi, On Wed, 2010-06-30 at 16:15 +0200, ext Afzal Mohammed wrote: > If enabling fb0 fails in omapfb_create_framebuffers(), remove > sysfs file before returning to probe. This is required to complete > the cleanup in the above mentioned error case. omapfb frees the resources in omapfb_free_resources(). I believe removing sysfs should also be put into omapfb_free_resources() to be consistent, and not as an explicit call like in this patch. However, I'm not sure if some sysfs-allocated flag is needed for this to work in all cases. Tomi