* [PATCH] OMAP2: OMAPFB: Fix invalid bpp for PAL and NTSC modes
@ 2010-07-21 22:40 Maurus Cuelenaere
2010-07-26 8:21 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Maurus Cuelenaere @ 2010-07-21 22:40 UTC (permalink / raw)
To: linux-fbdev, linux-omap, tomi.valkeinen; +Cc: ville.syrjala, tj
omapfb_mode_to_timings() sets the bpp to 0 when bootarg omapfb.mode is set to
either "pal" or "ntsc". This patch corrects this by setting the bpp to 24, as
would be done if omapdss_default_get_recommended_bpp() would be called
Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
---
drivers/video/omap2/omapfb/omapfb-main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 4b4506d..500458e 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -1968,11 +1968,11 @@ static int omapfb_mode_to_timings(const char *mode_str,
#ifdef CONFIG_OMAP2_DSS_VENC
if (strcmp(mode_str, "pal") = 0) {
*timings = omap_dss_pal_timings;
- *bpp = 0;
+ *bpp = 24;
return 0;
} else if (strcmp(mode_str, "ntsc") = 0) {
*timings = omap_dss_ntsc_timings;
- *bpp = 0;
+ *bpp = 24;
return 0;
}
#endif
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OMAP2: OMAPFB: Fix invalid bpp for PAL and NTSC modes
2010-07-21 22:40 [PATCH] OMAP2: OMAPFB: Fix invalid bpp for PAL and NTSC modes Maurus Cuelenaere
@ 2010-07-26 8:21 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2010-07-26 8:21 UTC (permalink / raw)
To: ext Maurus Cuelenaere
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
Syrjala Ville (Nokia-MS/Helsinki), tj@kernel.org
On Thu, 2010-07-22 at 00:40 +0200, ext Maurus Cuelenaere wrote:
> omapfb_mode_to_timings() sets the bpp to 0 when bootarg omapfb.mode is set to
> either "pal" or "ntsc". This patch corrects this by setting the bpp to 24, as
> would be done if omapdss_default_get_recommended_bpp() would be called
Thanks, applied to my tree.
Tomi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-26 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-21 22:40 [PATCH] OMAP2: OMAPFB: Fix invalid bpp for PAL and NTSC modes Maurus Cuelenaere
2010-07-26 8:21 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).