* [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check
2010-11-12 11:58 ` Belisko Marek
@ 2010-11-12 11:59 Samreen
2010-11-12 11:58 ` Belisko Marek
2010-11-12 12:07 ` Ville Syrjälä
0 siblings, 2 replies; 5+ messages in thread
From: Samreen @ 2010-11-12 11:59 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: linux-omap, linux-fbdev, Samreen
A null pointer check added.
Signed-off-by: Samreen <samreen@ti.com>
---
drivers/video/omap2/omapfb/omapfb-main.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 6a704f1..55bed89 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -2133,6 +2133,8 @@ static int omapfb_parse_def_modes(struct omapfb2_device *fbdev)
int r = 0;
str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL);
+ if (str = NULL)
+ return -EINVAL;
strcpy(str, def_mode);
options = str;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check
2010-11-12 11:59 [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check Samreen
@ 2010-11-12 11:58 ` Belisko Marek
2010-11-15 12:57 ` Nilofer, Samreen
2010-11-12 12:07 ` Ville Syrjälä
1 sibling, 1 reply; 5+ messages in thread
From: Belisko Marek @ 2010-11-12 11:58 UTC (permalink / raw)
To: Samreen; +Cc: Tomi Valkeinen, linux-omap, linux-fbdev
On Fri, Nov 12, 2010 at 12:47 PM, Samreen <samreen@ti.com> wrote:
> A null pointer check added.
>
> Signed-off-by: Samreen <samreen@ti.com>
> ---
> drivers/video/omap2/omapfb/omapfb-main.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
> index 6a704f1..55bed89 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -2133,6 +2133,8 @@ static int omapfb_parse_def_modes(struct omapfb2_device *fbdev)
> int r = 0;
>
> str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL);
> + if (str = NULL)
> + return -EINVAL;
Shouldn't be rerutn _ENNOMEM; instead to get correct error code?
> strcpy(str, def_mode);
> options = str;
>
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
thank,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check
2010-11-12 11:58 ` Belisko Marek
@ 2010-11-15 12:57 ` Nilofer, Samreen
0 siblings, 0 replies; 5+ messages in thread
From: Nilofer, Samreen @ 2010-11-15 12:57 UTC (permalink / raw)
To: Belisko Marek
Cc: Tomi Valkeinen, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org
Belisko Marek wrote:
> On Fri, Nov 12, 2010 at 12:47 PM, Samreen <samreen@ti.com> wrote:
>> A null pointer check added.
>>
>> Signed-off-by: Samreen <samreen@ti.com>
>> ---
>> drivers/video/omap2/omapfb/omapfb-main.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c
>> b/drivers/video/omap2/omapfb/omapfb-main.c
>> index 6a704f1..55bed89 100644
>> --- a/drivers/video/omap2/omapfb/omapfb-main.c
>> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
>> @@ -2133,6 +2133,8 @@ static int omapfb_parse_def_modes(struct
>> omapfb2_device *fbdev) int r = 0;
>>
>> str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL); + if (str =
>> NULL) + return -EINVAL;
> Shouldn't be rerutn _ENNOMEM; instead to get correct error code?
[Samreen]
Will fix this.
>> strcpy(str, def_mode);
>> options = str;
>>
>> --
>> 1.5.6.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap"
>> in the body of a message to majordomo@vger.kernel.org More majordomo
>> info at http://vger.kernel.org/majordomo-info.html
>>
> thank,
>
> marek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check
2010-11-12 11:59 [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check Samreen
2010-11-12 11:58 ` Belisko Marek
@ 2010-11-12 12:07 ` Ville Syrjälä
2010-11-15 12:58 ` Nilofer, Samreen
1 sibling, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2010-11-12 12:07 UTC (permalink / raw)
To: ext Samreen
Cc: Valkeinen Tomi (Nokia-MS/Helsinki), linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org
On Fri, Nov 12, 2010 at 12:47:15PM +0100, ext Samreen wrote:
> A null pointer check added.
>
> Signed-off-by: Samreen <samreen@ti.com>
> ---
> drivers/video/omap2/omapfb/omapfb-main.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
> index 6a704f1..55bed89 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -2133,6 +2133,8 @@ static int omapfb_parse_def_modes(struct omapfb2_device *fbdev)
> int r = 0;
>
> str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL);
> + if (str = NULL)
> + return -EINVAL;
> strcpy(str, def_mode);
While you're at it you could change the code to use kstrdup().
--
Ville Syrjälä
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check
2010-11-12 12:07 ` Ville Syrjälä
@ 2010-11-15 12:58 ` Nilofer, Samreen
0 siblings, 0 replies; 5+ messages in thread
From: Nilofer, Samreen @ 2010-11-15 12:58 UTC (permalink / raw)
To: Ville Syrjälä
Cc: Valkeinen Tomi (Nokia-MS/Helsinki), linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org
Ville Syrjälä wrote:
> On Fri, Nov 12, 2010 at 12:47:15PM +0100, ext Samreen wrote:
>> A null pointer check added.
>>
>> Signed-off-by: Samreen <samreen@ti.com>
>> ---
>> drivers/video/omap2/omapfb/omapfb-main.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c
>> b/drivers/video/omap2/omapfb/omapfb-main.c
>> index 6a704f1..55bed89 100644
>> --- a/drivers/video/omap2/omapfb/omapfb-main.c
>> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
>> @@ -2133,6 +2133,8 @@ static int
> omapfb_parse_def_modes(struct omapfb2_device *fbdev)
>> int r = 0;
>>
>> str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL);
>> + if (str = NULL)
>> + return -EINVAL;
>> strcpy(str, def_mode);
>
> While you're at it you could change the code to use kstrdup().
[Samreen]
Will use kstrdup() and post the patch soon.
Warm Regards,
Samreen
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-15 12:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-12 11:59 [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check Samreen
2010-11-12 11:58 ` Belisko Marek
2010-11-15 12:57 ` Nilofer, Samreen
2010-11-12 12:07 ` Ville Syrjälä
2010-11-15 12:58 ` Nilofer, Samreen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).