* [PATCH v2] OMAP: DSS2: OMAPFB: Add null pointer check
@ 2010-11-16 11:54 Samreen
2010-11-16 13:36 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Samreen @ 2010-11-16 11:54 UTC (permalink / raw)
To: Tomi Valkeinen, linux-omap; +Cc: linux-fbdev, Samreen
A null pointer check added. And using kstrdup()
instead of kmalloc() & strcpy()
Signed-off-by: Samreen <samreen@ti.com>
---
Version2:
- Using kstrdup() instead of kmalloc() & strcpy()
- Using ENOMEM as error code instead of EINVAL
- Subject changed appropriately
The link to v1 of patch is:
https://patchwork.kernel.org/patch/319642/
drivers/video/omap2/omapfb/omapfb-main.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 6a704f1..4fdab8e 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -2132,8 +2132,9 @@ static int omapfb_parse_def_modes(struct omapfb2_device *fbdev)
char *str, *options, *this_opt;
int r = 0;
- str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL);
- strcpy(str, def_mode);
+ str = kstrdup(def_mode, GFP_KERNEL);
+ if (!str)
+ return -ENOMEM;
options = str;
while (!r && (this_opt = strsep(&options, ",")) != NULL) {
--
1.5.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-16 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-16 11:54 [PATCH v2] OMAP: DSS2: OMAPFB: Add null pointer check Samreen
2010-11-16 13:36 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).