RE: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display

[Tomi Valkeinen <tomi.valkeinen@nokia.com>]

On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote:
> Hi,
>   Any more comments on this patch?

I'm not sure if enabling kernel options by default is a good thing.
Somehow I remember that enabling things by default is not looked kindly
at. Shouldn't they be enabled in the arch/arm/configs config file, if
they are wanted?

Tony, do you have opinnion on this? Should DSS features be enabled by
default in the Kconfig files, or only in the board config file?

Also, see one comment inline.

> Warm Regards,
> Samreen 
> Nilofer, Samreen wrote:
> > The defconfig options for display are taken in the respective
> > Kconfig to enable display by default on OMAP3 platforms
> > 
> > Signed-off-by: Samreen <samreen@ti.com>
> > ---
> >  Version4:
> >        Remove the enabling of the display panels by default.
> > 
> >  Version3:
> >        Eliminate the separate default number of FBs for
> > different architecture. Keeping default FBs as 3 as before.
> > 
> >  Version2:
> >         Enables by default NEC panel used in zoom2/3/3630sdp,
> > instead of  Sharp LQ043T1DG01 panel enabled in previous
> > version of this patch.
> > 
> >  drivers/video/omap2/dss/Kconfig    |    6 ++++--
> >  drivers/video/omap2/omapfb/Kconfig |    1 +
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/video/omap2/dss/Kconfig
> > b/drivers/video/omap2/dss/Kconfig index 43b6440..f3244a2 100644
> > --- a/drivers/video/omap2/dss/Kconfig
> > +++ b/drivers/video/omap2/dss/Kconfig
> > @@ -1,6 +1,7 @@
> >  menuconfig OMAP2_DSS
> >          tristate "OMAP2/3 Display Subsystem support (EXPERIMENTAL)"
> >          depends on ARCH_OMAP2 || ARCH_OMAP3
> > +	default y
> >          help
> >            OMAP2/3 Display Subsystem support.
> > 
> > @@ -9,7 +10,7 @@ if OMAP2_DSS
> >  config OMAP2_VRAM_SIZE
> >  	int "VRAM size (MB)"
> >  	range 0 32
> > -	default 0
> > +	default 4
> >  	help
> >  	  The amount of SDRAM to reserve at boot time for video RAM use.
> >  	  This VRAM will be used by omapfb and other drivers
> > that need @@ -102,7 +103,8 @@ config OMAP2_DSS_FAKE_VSYNC
> > config OMAP2_DSS_MIN_FCK_PER_PCK
> >  	int "Minimum FCK/PCK ratio (for scaling)"
> >  	range 0 32
> > -	default 0
> > +	default 4  if ARCH_OMAP2 || ARCH_OMAP3
> > +	default 0  if ARCH_OMAP4

I think having default ratio of 4 would mean that for example high res
modes wouldn't work on beagle. They require high pixel clock, which
requires 1/2 pck/lck ratio.

> >  	help
> >  	  This can be used to adjust the minimum FCK/PCK ratio.
> > 
> > diff --git a/drivers/video/omap2/omapfb/Kconfig
> > b/drivers/video/omap2/omapfb/Kconfig
> > index 65149b2..923bf48 100644
> > --- a/drivers/video/omap2/omapfb/Kconfig
> > +++ b/drivers/video/omap2/omapfb/Kconfig
> > @@ -1,6 +1,7 @@
> >  menuconfig FB_OMAP2
> >          tristate "OMAP2/3 frame buffer support (EXPERIMENTAL)"
> >          depends on FB && OMAP2_DSS
> > +	default y
> > 
> >  	select OMAP2_VRAM
> >  	select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3