[PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison

[PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison

[Andrew Kephart]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1132 bytes --]

Refresh rate nearness is not calculated or reset when nearest resolution
changes.

This patch resets the refresh rate differential measurement whenever a
new nearest resolution is discovered.  This fixes two error cases;
first, wherein the first mode's refresh rate differential is never
calculated and second, when the closest refresh rate from a previous
nearest resolution is erroneously preserved.

-andrew


diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c 
index c3a1825..7a61ba6 100644
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -902,6 +902,7 @@ const struct fb_videomode
*fb_find_nearest_mode(const struct fb_videomode *mode,
                        abs(cmode->yres - mode->yres);
                if (diff > d) {
                        diff = d;
+                       diff_refresh = abs(cmode->refresh -  mode->refresh);
                        best = cmode;
                } else if (diff = d) {
                        d = abs(cmode->refresh - mode->refresh);

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ýöÝzÿâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm

Re: [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison

[Paul Mundt]

On Fri, Dec 10, 2010 at 04:24:48PM -0600, Andrew Kephart wrote:
> Refresh rate nearness is not calculated or reset when nearest resolution
> changes.
> 
> This patch resets the refresh rate differential measurement whenever a
> new nearest resolution is discovered.  This fixes two error cases;
> first, wherein the first mode's refresh rate differential is never
> calculated and second, when the closest refresh rate from a previous
> nearest resolution is erroneously preserved.
> 
You're missing a signed-off-by tag.

Re: [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison

[Andrew Kephart]

Refresh rate nearness is not calculated or reset when nearest resolution
changes.

This patch resets the refresh rate differential measurement whenever a
new nearest resolution is discovered.  This fixes two error cases;
first, wherein the first mode's refresh rate differential is never
calculated and second, when the closest refresh rate from a previous
nearest resolution is erroneously preserved.

Signed-off-by: Andrew Kephart <andrew.kephart@alereon.com>
---

diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c 
index c3a1825..7a61ba6 100644
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -902,6 +902,7 @@ const struct fb_videomode
*fb_find_nearest_mode(const struct fb_videomode *mode,
                        abs(cmode->yres - mode->yres);
                if (diff > d) {
                        diff = d;
+                       diff_refresh = abs(cmode->refresh -
mode->refresh);
                        best = cmode;
                } else if (diff = d) {
                        d = abs(cmode->refresh - mode->refresh);

Re: [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison

[Paul Mundt]

On Mon, Dec 13, 2010 at 09:46:34AM -0600, Andrew Kephart wrote:
> Refresh rate nearness is not calculated or reset when nearest resolution
> changes.
> 
> This patch resets the refresh rate differential measurement whenever a
> new nearest resolution is discovered.  This fixes two error cases;
> first, wherein the first mode's refresh rate differential is never
> calculated and second, when the closest refresh rate from a previous
> nearest resolution is erroneously preserved.
> 
> Signed-off-by: Andrew Kephart <andrew.kephart@alereon.com>

The patch itself is line-wrapped, so please check your mailer settings
for future patches. I've applied it by hand this time, thanks.

Re: [PATCH] fbdev: Fix fb_find_nearest_mode refresh comparison

[Andrew Kephart]

Paul,

    Thanks, will do.

-andrew

On Tue, 2010-12-14 at 18:05 +0900, Paul Mundt wrote:

> The patch itself is line-wrapped, so please check your mailer settings
> for future patches. I've applied it by hand this time, thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html