From: Alex Buell <alex.buell@munted.org.uk>
To: David Miller <davem@davemloft.net>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Using s3virge card in Sun Blade 2000
Date: Wed, 05 Jan 2011 21:13:42 +0000 [thread overview]
Message-ID: <1294262022.24378.2.camel@lithium> (raw)
In-Reply-To: <20110105.110705.104043006.davem@davemloft.net>
On Wed, 2011-01-05 at 11:07 -0800, David Miller wrote:
> > Those are 32 bit addresses, so I suppose I should be getting the
> base
> > address for the registers accesses from region 1, right?
>
> Actually, I take back what I said earlier. Region 1 is a Memory
> region not an I/O region.
>
> It looks like you'll have to find a way to get at the implicit
> I/O space for the PCI domain this framebuffer is behind and
> construct the implicit VGA addresses by hand.
>
> There is a way to do this, via pcibios_bus_to_resource(). You could
> do something like:
>
> struct s3fb_info {
> ...
> void __iomem *vga_iobase;
> ...
> static int __devinit s3_pci_probe(struct pci_dev *dev, const struct
> pci_device_id *id)
> {
> struct pci_bus_region bus_reg;
> struct resource vga_res;
> ...
> bus_reg.start = 0;
> bus_reg.end = 64 * 1024;
>
> vga_res.flags = IORESOURCE_IO;
>
> pcibios_bus_to_resource(dev, &bus_reg, &vga_res);
>
> par->vga_iobase = (void __iomem *) vga_res.start;
>
> Then replace all NULL vga_*() initial arguments in the driver
> with par->vga_iobase.
No wonder it was crashing, there was nothing to access with region 1! I
will do as you suggest, and see if it works. Thank you!
--
Tactical Nuclear Kittens
next prev parent reply other threads:[~2011-01-05 21:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 16:32 Using s3virge card in Sun Blade 2000 Alex Buell
2011-01-03 18:58 ` David Miller
2011-01-03 19:39 ` Alex Buell
2011-01-03 19:43 ` David Miller
2011-01-03 20:33 ` Alex Buell
2011-01-03 20:39 ` David Miller
2011-01-03 21:36 ` Alex Buell
2011-01-03 22:36 ` David Miller
2011-01-04 15:57 ` Alex Buell
2011-01-04 17:26 ` David Miller
2011-01-04 20:11 ` Alex Buell
2011-01-04 20:19 ` David Miller
2011-01-04 20:38 ` Alex Buell
2011-01-05 19:07 ` David Miller
2011-01-05 21:13 ` Alex Buell [this message]
2011-01-06 0:33 ` Alex Buell
2011-01-06 20:42 ` Francois Romieu
2011-01-06 20:50 ` Alex Buell
2011-01-06 22:24 ` Alex Buell
2011-01-06 22:29 ` David Miller
2011-01-06 23:25 ` Alex Buell
2011-01-06 23:34 ` Alex Buell
2011-01-03 20:37 ` Dave Airlie
2011-01-05 20:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294262022.24378.2.camel@lithium \
--to=alex.buell@munted.org.uk \
--cc=davem@davemloft.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).