From: Alexander Stein <alexander.stein@systec-electronic.com>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH] mx3fb: Fix parameter to sdc_init_panel
Date: Thu, 10 Feb 2011 10:05:30 +0000 [thread overview]
Message-ID: <1297332330-21964-1-git-send-email-alexander.stein@systec-electronic.com> (raw)
h_end_width and v_end_width should only contain the front porches.
Otherwise, SCREEN_WIDTH (pixel clocks between HSYNC) in SDC_HOR_CONF
and SCREEN_HEIGHT (rows between VSYNC) in SDC_VER_CONF get false values.
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
drivers/video/mx3fb.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index ef71e56..9040833 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c
@@ -881,12 +881,11 @@ static int __set_par(struct fb_info *fbi, bool lock)
IPU_PIX_FMT_BGR666 : IPU_PIX_FMT_RGB666,
fbi->var.left_margin,
fbi->var.hsync_len,
- fbi->var.right_margin +
- fbi->var.hsync_len,
+ fbi->var.right_margin,
fbi->var.upper_margin,
fbi->var.vsync_len,
- fbi->var.lower_margin +
- fbi->var.vsync_len, sig_cfg) != 0) {
+ fbi->var.lower_margin,
+ sig_cfg) != 0) {
dev_err(fbi->device,
"mx3fb: Error initializing panel.\n");
return -EINVAL;
--
1.7.3.4
next reply other threads:[~2011-02-10 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 10:05 Alexander Stein [this message]
2011-02-10 10:44 ` [PATCH] mx3fb: Fix parameter to sdc_init_panel Guennadi Liakhovetski
2011-02-10 11:00 ` Guennadi Liakhovetski
2011-02-10 11:27 ` Alexander Stein
2011-02-10 12:48 ` Guennadi Liakhovetski
2011-02-10 13:01 ` Alexander Stein
2011-02-14 7:46 ` Alexander Stein
2011-02-14 7:57 ` Guennadi Liakhovetski
2011-02-14 12:06 ` Alexander Stein
2011-02-16 13:47 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297332330-21964-1-git-send-email-alexander.stein@systec-electronic.com \
--to=alexander.stein@systec-electronic.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).