* [PATCH] video: s3c-fb: return proper error if clk_get fails
@ 2011-02-11 8:51 Axel Lin
2011-02-14 0:19 ` Kyungmin Park
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-02-11 8:51 UTC (permalink / raw)
To: linux-kernel; +Cc: Kyungmin Park, Ben Dooks, Paul Mundt, linux-fbdev
Return PTR_ERR(sfb->bus_clk) instead of 0 if clk_get fails.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/s3c-fb.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index 83ce9a0..6817d18 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -1340,6 +1340,7 @@ static int __devinit s3c_fb_probe(struct platform_device *pdev)
sfb->bus_clk = clk_get(dev, "lcd");
if (IS_ERR(sfb->bus_clk)) {
dev_err(dev, "failed to get bus clock\n");
+ ret = PTR_ERR(sfb->bus_clk);
goto err_sfb;
}
--
1.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] video: s3c-fb: return proper error if clk_get fails
2011-02-11 8:51 [PATCH] video: s3c-fb: return proper error if clk_get fails Axel Lin
@ 2011-02-14 0:19 ` Kyungmin Park
0 siblings, 0 replies; 2+ messages in thread
From: Kyungmin Park @ 2011-02-14 0:19 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Ben Dooks, Paul Mundt, linux-fbdev
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
On Fri, Feb 11, 2011 at 5:51 PM, Axel Lin <axel.lin@gmail.com> wrote:
> Return PTR_ERR(sfb->bus_clk) instead of 0 if clk_get fails.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/s3c-fb.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 83ce9a0..6817d18 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -1340,6 +1340,7 @@ static int __devinit s3c_fb_probe(struct platform_device *pdev)
> sfb->bus_clk = clk_get(dev, "lcd");
> if (IS_ERR(sfb->bus_clk)) {
> dev_err(dev, "failed to get bus clock\n");
> + ret = PTR_ERR(sfb->bus_clk);
> goto err_sfb;
> }
>
> --
> 1.7.2
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-14 0:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-11 8:51 [PATCH] video: s3c-fb: return proper error if clk_get fails Axel Lin
2011-02-14 0:19 ` Kyungmin Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).