* [PATCH] omapfb: Fix linker error in drivers/video/omap/lcd_2430sdp.c
[not found] <1298905757.9809.135.camel@deskari>
@ 2011-03-01 8:40 ` Jarkko Nikula
2011-03-02 7:58 ` [PATCH] omapfb: Fix linker error in Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Jarkko Nikula @ 2011-03-01 8:40 UTC (permalink / raw)
To: linux-fbdev; +Cc: linux-omap, Tomi Valkeinen, Jarkko Nikula
There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not
set. This can be triggered on OMAP2 builds when OMAP3 or OMAP4 are not set.
drivers/built-in.o: In function `sdp2430_panel_disable':
drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8'
drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8'
drivers/built-in.o: In function `sdp2430_panel_enable':
drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8'
drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8'
Fix this by selecting the TWL4030_CORE for MACH_OMAP_2430SDP when building
with CONFIG_FB_OMAP as there is no own Kconfig entry for lcd_2430 and it is
compiled always when both MACH_OMAP_2430SDP and FB_OMAP are set.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
Quite old issue probably. I don't think any fancier fix is required as this
is legacy omapfb code?
---
drivers/video/omap/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
index 083c8fe..c981249 100644
--- a/drivers/video/omap/Kconfig
+++ b/drivers/video/omap/Kconfig
@@ -5,6 +5,7 @@ config FB_OMAP
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select TWL4030_CORE if MACH_OMAP_2430SDP
help
Frame buffer driver for OMAP based boards.
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] omapfb: Fix linker error in
2011-03-01 8:40 ` [PATCH] omapfb: Fix linker error in drivers/video/omap/lcd_2430sdp.c Jarkko Nikula
@ 2011-03-02 7:58 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2011-03-02 7:58 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org
On Tue, 2011-03-01 at 02:40 -0600, Jarkko Nikula wrote:
> There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not
> set. This can be triggered on OMAP2 builds when OMAP3 or OMAP4 are not set.
>
> drivers/built-in.o: In function `sdp2430_panel_disable':
> drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8'
> drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8'
> drivers/built-in.o: In function `sdp2430_panel_enable':
> drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8'
> drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8'
>
> Fix this by selecting the TWL4030_CORE for MACH_OMAP_2430SDP when building
> with CONFIG_FB_OMAP as there is no own Kconfig entry for lcd_2430 and it is
> compiled always when both MACH_OMAP_2430SDP and FB_OMAP are set.
Thanks, applied.
Tomi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-02 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1298905757.9809.135.camel@deskari>
2011-03-01 8:40 ` [PATCH] omapfb: Fix linker error in drivers/video/omap/lcd_2430sdp.c Jarkko Nikula
2011-03-02 7:58 ` [PATCH] omapfb: Fix linker error in Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).