From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Petr Vandrovec" Subject: Re: fb_imageblit semantic Date: Fri, 14 Mar 2003 11:18:47 +0100 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <12BA37FB2AC0@vcnet.vc.cvut.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailgw.cvut.cz ([147.32.3.235]) by sc8-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 18tmHN-0002NI-00 for ; Fri, 14 Mar 2003 02:19:10 -0800 Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Geert Uytterhoeven Cc: James Simmons , Linux Frame Buffer Device Development On 14 Mar 03 at 10:22, Geert Uytterhoeven wrote: > On Thu, 13 Mar 2003, Petr Vandrovec wrote: > > Why do you pass image.depth == 16 (or 24 or 32) to fb_imageblit > > when logo image is in reality always 8bpp, as quick look at > > cfb_imageblit revealed? > > Should indeed be 8. > > > Should I just assume that image.depth == 1 means that data are > > 1bpp with fgcol/bgcol valid, and all other depths mean 8bpp > > input? > > This was changed from 1 to 0 in James' latest tree. WTF? Color depth 0 means that whole picture is single-color, and imageblit degenerates to rectfill in such case. Please, either use 'depth' as source image color depth, or do not name it depth. Petr Vandrovec ------------------------------------------------------- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en