From: Tormod Volden <lists.tormod@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH 1/2] savagefb: Replace magic register address with define
Date: Sun, 03 Apr 2011 12:54:04 +0000 [thread overview]
Message-ID: <1301835246-6520-1-git-send-email-lists.tormod@gmail.com> (raw)
From: Tormod Volden <debian.tormod@gmail.com>
MM_SERIAL1 was already defined, but not used.
Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
---
Hi,
There was this unused define, and the one single use of the constant, so
I think somebody just forgot to use it.
Regards,
Tormod
drivers/video/savage/savagefb-i2c.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/savage/savagefb-i2c.c b/drivers/video/savage/savagefb-i2c.c
index b16e613..58c8a3c 100644
--- a/drivers/video/savage/savagefb-i2c.c
+++ b/drivers/video/savage/savagefb-i2c.c
@@ -191,7 +191,7 @@ void savagefb_create_i2c_busses(struct fb_info *info)
par->chan.algo.getscl = prosavage_gpio_getscl;
break;
case FB_ACCEL_SAVAGE2000:
- par->chan.reg = 0xff20;
+ par->chan.reg = MM_SERIAL1;
par->chan.ioaddr = par->mmio.vbase;
par->chan.algo.setsda = savage4_gpio_setsda;
par->chan.algo.setscl = savage4_gpio_setscl;
--
1.7.0.4
next reply other threads:[~2011-04-03 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 12:54 Tormod Volden [this message]
2011-04-06 16:50 ` [PATCH 1/2] savagefb: Replace magic register address with define Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301835246-6520-1-git-send-email-lists.tormod@gmail.com \
--to=lists.tormod@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).