From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liu Yuan Date: Thu, 14 Apr 2011 08:17:50 +0000 Subject: [PATCH] video, udlfb: Fix two build warning about 'ignoring return value' Message-Id: <1302769070-21670-1-git-send-email-namei.unix@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Paul Mundt Cc: "open list:FRAMEBUFFER LAYER" , open list From: Liu Yuan Build warning: ... drivers/video/udlfb.c:1590: warning: ignoring return value of ‘device_create_file’, declared with attribute warn_unused_result drivers/video/udlfb.c:1592: warning: ignoring return value of ‘device_create_bin_file’, declared with attribute warn_unused_result So add two checks to get rid of 'em. Signed-off-by: Liu Yuan --- drivers/video/udlfb.c | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c index 68041d9..55d6de6 100644 --- a/drivers/video/udlfb.c +++ b/drivers/video/udlfb.c @@ -1586,10 +1586,19 @@ static int dlfb_usb_probe(struct usb_interface *interface, goto error; } - for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) - device_create_file(info->dev, &fb_device_attrs[i]); + for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) { + retval = device_create_file(info->dev, &fb_device_attrs[i]); + if (retval) { + pr_err("device_create_file failed %d\n", retval); + goto error; + } + } - device_create_bin_file(info->dev, &edid_attr); + retval = device_create_bin_file(info->dev, &edid_attr); + if (retval) { + pr_err("device_create_bin_file failed %d\n", retval); + goto error; + } pr_info("DisplayLink USB device /dev/fb%d attached. %dx%d resolution." " Using %dK framebuffer memory\n", info->node, -- 1.7.1