From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Petr Vandrovec" Subject: Re: fb_imageblit semantic Date: Mon, 17 Mar 2003 11:40:08 +0100 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <130293E23DB3@vcnet.vc.cvut.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7BIT Return-path: Received: from mailgw.cvut.cz ([147.32.3.235]) by sc8-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 18us2h-0007Fc-00 for ; Mon, 17 Mar 2003 02:40:31 -0800 Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Geert Uytterhoeven Cc: James Simmons , Linux Frame Buffer Device Development , adaplas@pol.net On 17 Mar 03 at 11:31, Geert Uytterhoeven wrote: > On 17 Mar 2003, Antonino Daplas wrote: > > As Geert said, it's not just trivial, but logical to split fb_imageblit > > into two. > > So, are we gonna split it? This will also make hardware acceleration support > more clean. E.g. most sbus drivers do color expansion in hardware, and fall > back to cfb_imageblit() for the logo. > > > > OK, so rule is that if depth=0, input is 1bpp with palette in bgcol/fgcol, > > > while if depth != 0, then palette is in info->pseudo_palette ? > > > > Yes. You can also say that if image->depth != var->bits_per_pixel, do > > color expansion or reduction, whatever the case may be. > > Hmmm... Note that image->depth can be larger than 8, while the image data is > still 8-bit. This is an inconsistency. image->depth for logo must change to 8. Or remove depth completely after splitting imageblit to paintchar & paintlogo, as currently depth is useless anyway: target format is defined by framebuffer layout, not by image->depth, and source format is hardwired to the code. Petr Vandrovec vandrove@vc.cvut.cz ------------------------------------------------------- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en