From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Niels de Vos <ndevos@redhat.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Sanjeev Premi <premi@ti.com>
Subject: Re: [PATCH V2] omap2/omapfb: make DBG() more resistant in if-else
Date: Tue, 10 May 2011 12:16:07 +0000 [thread overview]
Message-ID: <1305029767.2045.42.camel@deskari> (raw)
In-Reply-To: <1305025653-17138-1-git-send-email-ndevos@redhat.com>
On Tue, 2011-05-10 at 12:07 +0100, Niels de Vos wrote:
> When DBG() is used in a simple if-else, the resulting code path
> currently depends on the definition of DBG(). Inserting the statement in
> a "do { ... } while (0)" prevents this possible misuse.
>
> Signed-off-by: Niels de Vos <ndevos@redhat.com>
Thanks, I'll add this to the dss2 tree.
Tomi
next prev parent reply other threads:[~2011-05-10 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 9:20 [PATCH] omap2/omapfb: make DBG() more resistant in if-else constructions Niels de Vos
2011-05-10 9:42 ` Geert Uytterhoeven
2011-05-10 10:57 ` Niels de Vos
2011-05-10 11:07 ` [PATCH V2] " Niels de Vos
2011-05-10 12:16 ` Tomi Valkeinen [this message]
2011-05-10 12:08 ` [PATCH] omap2/omapfb: make DBG() more resistant in if-else Tomi Valkeinen
2011-05-10 12:14 ` [PATCH] omap2/omapfb: make DBG() more resistant in if-else constructions Geert Uytterhoeven
2011-05-10 9:49 ` [PATCH] omap2/omapfb: make DBG() more resistant in if-else Premi, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305029767.2045.42.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ndevos@redhat.com \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).