From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Date: Wed, 18 May 2011 11:01:47 +0000 Subject: Re: [PATCH 2/2] trivial: Changed the printk loglevel when not able Message-Id: <1305716507.11468.68.camel@e102109-lin.cambridge.arm.com> List-Id: References: <1305653342.2182.15.camel@anish-desktop> <1305713710.11468.39.camel@e102109-lin.cambridge.arm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: anish singh Cc: linux@arm.linux.org.uk, lethal@linux-sh.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 2011-05-18 at 11:57 +0100, anish singh wrote: > On Wed, May 18, 2011 at 3:45 PM, Catalin Marinas wrote: > > On Wed, 2011-05-18 at 04:19 +0100, anish singh wrote: > > On Tue, May 17, 2011 at 11:13 PM, Catalin Marinas wrote: > > On 17 May 2011 18:29, anish wrote: > > > When not able to allocate memory we were using KERN_INFO as > > > log level in printk so changed to KERN_ERR > > > Signed-off-by: anish kumar > > > > > > Maybe KERN_WARN? > > Then shouldn't we change below case also? > > 467 ret = amba_request_regions(dev, NULL); > > 468 if (ret) { > > 469 printk(KERN_ERR "CLCD: unable to reserve regs region\n"); > > 470 goto out; > > > > If yes,then i will resend the patch for this also. > > > I think the register reserving is less likely to fail because of memory > allocations but more because of overlapping regions, in which case it > could be a programming error. > > Allocating a big framebuffer is likely to fail in some memory constraint > systems but I don't consider this a kernel error. That's why I suggested > warning. > > Got it.So should i change both as KERN_WARN and resend? No, just the one KERN_INFO one. Anyway, Russell King is the maintainer of this driver so it's up to him to ack the patch (and don't forget to cc him). -- Catalin