* [PATCH v2 08/29] fbdev: unicore32: use display information in info not in var for panning
@ 2011-06-14 9:24 Laurent Pinchart
2011-06-15 2:40 ` [PATCH v2 08/29] fbdev: unicore32: use display information in Guan Xuetao
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2011-06-14 9:24 UTC (permalink / raw)
To: linux-fbdev
We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
---
drivers/video/fb-puv3.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fb-puv3.c b/drivers/video/fb-puv3.c
index 27f2c57..60a787f 100644
--- a/drivers/video/fb-puv3.c
+++ b/drivers/video/fb-puv3.c
@@ -624,8 +624,8 @@ static int unifb_pan_display(struct fb_var_screeninfo *var,
|| var->xoffset)
return -EINVAL;
} else {
- if (var->xoffset + var->xres > info->var.xres_virtual ||
- var->yoffset + var->yres > info->var.yres_virtual)
+ if (var->xoffset + info->var.xres > info->var.xres_virtual ||
+ var->yoffset + info->var.yres > info->var.yres_virtual)
return -EINVAL;
}
info->var.xoffset = var->xoffset;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 08/29] fbdev: unicore32: use display information in
2011-06-14 9:24 [PATCH v2 08/29] fbdev: unicore32: use display information in info not in var for panning Laurent Pinchart
@ 2011-06-15 2:40 ` Guan Xuetao
0 siblings, 0 replies; 2+ messages in thread
From: Guan Xuetao @ 2011-06-15 2:40 UTC (permalink / raw)
To: linux-fbdev
On Tue, 2011-06-14 at 11:24 +0200, Laurent Pinchart wrote:
> We must not use any information in the passed var besides xoffset,
> yoffset and vmode as otherwise applications might abuse it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> ---
> drivers/video/fb-puv3.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fb-puv3.c b/drivers/video/fb-puv3.c
> index 27f2c57..60a787f 100644
> --- a/drivers/video/fb-puv3.c
> +++ b/drivers/video/fb-puv3.c
> @@ -624,8 +624,8 @@ static int unifb_pan_display(struct fb_var_screeninfo *var,
> || var->xoffset)
> return -EINVAL;
> } else {
> - if (var->xoffset + var->xres > info->var.xres_virtual ||
> - var->yoffset + var->yres > info->var.yres_virtual)
> + if (var->xoffset + info->var.xres > info->var.xres_virtual ||
> + var->yoffset + info->var.yres > info->var.yres_virtual)
> return -EINVAL;
> }
> info->var.xoffset = var->xoffset;
Tested-and-Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
Thanks.
Guan Xuetao
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-15 2:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-14 9:24 [PATCH v2 08/29] fbdev: unicore32: use display information in info not in var for panning Laurent Pinchart
2011-06-15 2:40 ` [PATCH v2 08/29] fbdev: unicore32: use display information in Guan Xuetao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).