From mboxrd@z Thu Jan  1 00:00:00 1970
From: Guan Xuetao <gxt@mprc.pku.edu.cn>
Date: Wed, 15 Jun 2011 02:40:57 +0000
Subject: Re: [PATCH v2 08/29] fbdev: unicore32: use display information in
Message-Id: <1308105657.4727.11.camel@epip-laptop>
List-Id: <linux-fbdev.vger.kernel.org>
References: <1308043507-11083-9-git-send-email-laurent.pinchart@ideasonboard.com>
In-Reply-To: <1308043507-11083-9-git-send-email-laurent.pinchart@ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-fbdev@vger.kernel.org

On Tue, 2011-06-14 at 11:24 +0200, Laurent Pinchart wrote:
> We must not use any information in the passed var besides xoffset,
> yoffset and vmode as otherwise applications might abuse it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> ---
>  drivers/video/fb-puv3.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fb-puv3.c b/drivers/video/fb-puv3.c
> index 27f2c57..60a787f 100644
> --- a/drivers/video/fb-puv3.c
> +++ b/drivers/video/fb-puv3.c
> @@ -624,8 +624,8 @@ static int unifb_pan_display(struct fb_var_screeninfo *var,
>  		    || var->xoffset)
>  			return -EINVAL;
>  	} else {
> -		if (var->xoffset + var->xres > info->var.xres_virtual ||
> -		    var->yoffset + var->yres > info->var.yres_virtual)
> +		if (var->xoffset + info->var.xres > info->var.xres_virtual ||
> +		    var->yoffset + info->var.yres > info->var.yres_virtual)
>  			return -EINVAL;
>  	}
>  	info->var.xoffset = var->xoffset;
Tested-and-Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>

Thanks.
Guan Xuetao