From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <a0393947@ti.com>
Cc: Dima Zavin <dima@android.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP: DSS: dispc: enable/disable clocks in error
Date: Wed, 29 Jun 2011 04:58:07 +0000 [thread overview]
Message-ID: <1309323487.1829.9.camel@deskari> (raw)
In-Reply-To: <4E09FEFD.9020005@ti.com>
On Tue, 2011-06-28 at 09:19 -0700, Archit Taneja wrote:
> Hi,
>
> On Monday 27 June 2011 10:31 AM, Dima Zavin wrote:
> > There's no guarantee that the error handler worker thread
> > will run while the dispc clocks are on. Explicitly enable/disable
> > them.
>
> I agree with this.
Yes, I think this patch is fine. I'll apply it to DSS tree.
> Tomi,
>
> We could get prevent scheduling of the error worker by registering
> omap_dispc_irq_handler() as an interrupt thread.
But then we would get extra latency on the interrupt handlers. I wanted
to keep handling DSS interrupts in interrupt context, because some use
cases may require very fast reaction to an interrupt.
Tomi
next prev parent reply other threads:[~2011-06-29 4:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 17:31 [PATCH] OMAP: DSS: dispc: enable/disable clocks in error handler Dima Zavin
2011-06-28 16:19 ` Archit Taneja
2011-06-29 4:58 ` Tomi Valkeinen [this message]
2011-06-29 17:02 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309323487.1829.9.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=a0393947@ti.com \
--cc=dima@android.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).