From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Wed, 29 Jun 2011 04:58:07 +0000 Subject: Re: [PATCH] OMAP: DSS: dispc: enable/disable clocks in error Message-Id: <1309323487.1829.9.camel@deskari> List-Id: References: <1309195865-23808-1-git-send-email-dima@android.com> <4E09FEFD.9020005@ti.com> In-Reply-To: <4E09FEFD.9020005@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Archit Taneja Cc: Dima Zavin , "linux-fbdev@vger.kernel.org" , "linux-omap@vger.kernel.org" On Tue, 2011-06-28 at 09:19 -0700, Archit Taneja wrote: > Hi, > > On Monday 27 June 2011 10:31 AM, Dima Zavin wrote: > > There's no guarantee that the error handler worker thread > > will run while the dispc clocks are on. Explicitly enable/disable > > them. > > I agree with this. Yes, I think this patch is fine. I'll apply it to DSS tree. > Tomi, > > We could get prevent scheduling of the error worker by registering > omap_dispc_irq_handler() as an interrupt thread. But then we would get extra latency on the interrupt handlers. I wanted to keep handling DSS interrupts in interrupt context, because some use cases may require very fast reaction to an interrupt. Tomi