Re: [PATCH 2/4] OMAP4: TWL: Add common omapdss supplies

Archit Taneja
2011-09-02T06:52:00Z

Hi,

On Monday 22 August 2011 01:56 PM, Valkeinen, Tomi wrote:
> OMAP DSS normally gets power from VCXIO on OMAP4. Add configuration for
> this into twl-common.c
>
> Mark VCXIO as always_on, as VCXIO is used by multiple components,
> including the MPU, and turning it off when DSS doesn't need it would
> lead the device to halt.

I had a query. Is this the right place to set always_on to true? Won't
this lead to VCXIO being always on all omap4 boards? Is it necessary
that VCXIO will be used to power on MPU for all omap4 boards?

Archit

>
> Signed-off-by: Tomi Valkeinen<tomi.valkeinen@ti.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index 4f6d216..52243577 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -235,6 +235,12 @@ static struct regulator_init_data omap4_vana_idata = {
> },
> };
>
> +static struct regulator_consumer_supply omap4_vcxio_supply[] = {
> + REGULATOR_SUPPLY("vdds_dsi", "omapdss_dss"),
> + REGULATOR_SUPPLY("vdds_dsi", "omapdss_dsi.0"),
> + REGULATOR_SUPPLY("vdds_dsi", "omapdss_dsi.1"),
> +};
> +
> static struct regulator_init_data omap4_vcxio_idata = {
> .constraints = {
> .min_uV = 1800000,
> @@ -243,7 +249,10 @@ static struct regulator_init_data omap4_vcxio_idata = {
> | REGULATOR_MODE_STANDBY,
> .valid_ops_mask = REGULATOR_CHANGE_MODE
> | REGULATOR_CHANGE_STATUS,
> + .always_on = true,
> },
> + .num_consumer_supplies = ARRAY_SIZE(omap4_vcxio_supply),
> + .consumer_supplies = omap4_vcxio_supply,
> };
>
> static struct regulator_init_data omap4_vusb_idata = {