From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Cc: archit@ti.com, Tomi Valkeinen <tomi.valkeinen@ti.com>,
Mythri P K <mythripk@ti.com>
Subject: [PATCHv2 8/8] OMAP: DSS2: HDMI: improve hdmi output enable
Date: Mon, 12 Sep 2011 09:12:53 +0000 [thread overview]
Message-ID: <1315818773-18660-9-git-send-email-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <1315818773-18660-1-git-send-email-tomi.valkeinen@ti.com>
Enabling HDMI output often causes sync lost errors, and almost always
causes timeout errors being printed from dispc_mgr_enable_digit_out().
The sync lost problem seems to go lessen greatly if we first enable the
HDMI output, and only then enable the DISPC output. However, as this is
only based on observations, the fix may not be perfect as the problem
may lie somewhere else. Nevertheless, HDMI works better with this patch.
This will also fix the dispc's dispc_mgr_enable_digit_out(), as the code
waits for two VSYNCs after enabling the output. If the HDMI output is
disabled (as it was previously), there are no VSYNCs and
dispc_mgr_enable_digit_out() will print timeout errors.
Cc: Mythri P K <mythripk@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
drivers/video/omap2/dss/hdmi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index 4752137..06a78b2 100644
--- a/drivers/video/omap2/dss/hdmi.c
+++ b/drivers/video/omap2/dss/hdmi.c
@@ -529,10 +529,10 @@ static int hdmi_power_on(struct omap_dss_device *dssdev)
dispc_set_digit_size(dssdev->panel.timings.x_res,
dssdev->panel.timings.y_res);
- dispc_mgr_enable(OMAP_DSS_CHANNEL_DIGIT, 1);
-
hdmi.ip_data.ops->video_enable(&hdmi.ip_data, 1);
+ dispc_mgr_enable(OMAP_DSS_CHANNEL_DIGIT, 1);
+
return 0;
err:
hdmi_runtime_put();
--
1.7.4.1
next prev parent reply other threads:[~2011-09-12 9:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 9:12 [PATCHv2 0/8] OMAP: DSS2: misc improvements Tomi Valkeinen
2011-09-12 9:12 ` [PATCHv2 1/8] OMAP: DSS2: DISPC: Fix minimum PCD value Tomi Valkeinen
2011-09-12 9:12 ` [PATCHv2 2/8] OMAP: DSS2: HDMI: use default dividers Tomi Valkeinen
2011-09-12 9:12 ` [PATCHv2 3/8] OMAP: DSS2: HDMI: change regn definition Tomi Valkeinen
2011-09-12 9:12 ` [PATCHv2 4/8] OMAP: DSS2: DSI: Add comment about regn Tomi Valkeinen
2011-09-12 9:12 ` [PATCHv2 5/8] OMAP: DSS2: DISPC: Add missing IRQ definitions Tomi Valkeinen
2011-09-12 9:12 ` [PATCHv2 6/8] OMAP: DSS2: add dss_get_hdmi_venc_clk_source() Tomi Valkeinen
2011-09-12 9:12 ` [PATCHv2 7/8] OMAP: DSS2: DISPC: improve dispc_mgr_enable_digit_out() Tomi Valkeinen
2011-09-12 9:12 ` Tomi Valkeinen [this message]
2011-09-12 11:13 ` [PATCHv2 8/8] OMAP: DSS2: HDMI: improve hdmi output enable Archit Taneja
2011-09-12 11:06 ` Tomi Valkeinen
2011-09-12 11:35 ` Archit Taneja
2011-09-12 11:29 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315818773-18660-9-git-send-email-tomi.valkeinen@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).